[KARAF-5753] #504
[KARAF-5753] #504
Conversation
| 'hp-ux')PID_COMMAND=$(UNIX95= ps -p "${ROOT_INSTANCE_PID}" -o args | sed 1d);; | ||
| *)PID_COMMAND=$(ps -p "${ROOT_INSTANCE_PID}" -o args | sed 1d);; | ||
| esac | ||
| if [ "${PID_COMMAND#*$MAIN}" != "$PID_COMMAND" ]; then |
There was a problem hiding this comment.
Would you mind leveraging and extending the detectos function instead ? https://github.com/apache/karaf/blob/master/assemblies/features/base/src/main/filtered-resources/resources/bin/inc#L28-L57
There was a problem hiding this comment.
As requested, we updated the detectos function to add a specific variable to be associated with the ps command on HP-UX platforms when the -o option is used.
This was not mentioned on the KARAF-5753 but we also provide an improvement for the following line in shell scripts:
if [ -z $READLINK_EXISTS ]; then
$READLINK_EXISTS was not protected, causing error message on some platforms where the variable was empty (see below):
client[2]: test: Specify a parameter with this command.
client[17]: readlink: not found.
| HP-UX*) | ||
| hpux=true | ||
| # For HP-UX, set an environment variable | ||
| export PS_PREFIX="UNIX95= " |
There was a problem hiding this comment.
Could you just fix the indentation with spaces and remove the leading tab please ?
Updating indentation
|
Tested on HP-UX B.11.31 ia64 with HP JDK 8 Java(TM) SE Runtime Environment (build 1.8.0.12-hp-ux-b1) |
[ENTESB-17660] Revert "[KARAF-7159] Upgrade to Felix FileInstall 3.7.0"
4 participants
No description provided.