Add an example of using Jersey in karaf #633

steinarb · 2018-10-10T21:44:09Z

No description provided.

steinarb · 2018-10-11T06:13:17Z

The failure is:

[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project karaf: Too many files with unapproved license: 4 See RAT report in: /home/jenkins/jenkins-slave/workspace/karaf-pr/target/karaf-4.2.2-SNAPSHOT.rat -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project karaf: Too many files with unapproved license: 4 See RAT report in: /home/jenkins/jenkins-slave/workspace/karaf-pr/target/karaf-4.2.2-SNAPSHOT.rat

I put the same copyright headers on files that I found in other example projects. If that was wrong, tell me what to use and I will use it.

jbonofre · 2018-10-11T07:43:49Z

The following files don't contain the ASF headers:

  examples/karaf-jersey-example/karaf-jersey-example.webgui/src/main/resources/index.xhtml
  examples/karaf-jersey-example/karaf-jersey-example.webgui/src/main/feature/feature.xml
  examples/karaf-jersey-example/src/main/filtered-resources/feature.xml
  examples/karaf-jersey-example/karaf-jersey-example.webapi/src/main/feature/feature.xml

Can you please fix that ?

steinarb · 2018-10-12T05:59:47Z

The failure cause of the jenkins build this time, was a failing iTest that should not be affected by this new example:
https://builds.apache.org/job/karaf-pr/org.apache.karaf.itests$tests/738/testReport/junit/org.apache.karaf.itests.examples/JpaExampleTest/test/

fpapon · 2018-10-12T06:17:00Z

Yes, we have a flacky test on the example. We will fix it.

steinarb · 2018-10-12T18:24:53Z

Do I need to merge in the newest from master?

steinarb · 2018-10-12T20:57:08Z

I don't understand the current jenkins errors. There seems to be a repository confusion error that I don't know how to fix (jenkins tries to fetch from the karaf repository, instead of the repository where my branch lives).

jbonofre · 2018-10-13T05:16:33Z

@steinarb yes, it's a random issue between Jenkins and github. No need to rebase, let me deal with that.

jbonofre

Overall good. I have some cosmetic changes I will do.

jbonofre · 2018-10-14T05:32:12Z

examples/karaf-jersey-example/karaf-jersey-example.servicedef/pom.xml

+    -->
+
+    <modelVersion>4.0.0</modelVersion>
+    <artifactId>karaf-jersey-example.servicedef</artifactId>


In order to be consistent with the other example, I think it would be better to use karaf-jersey-example-service.

Looking at the other examples in karaf/examples/ the service definitions seem to reside in a module with name ending in "-api", like e.g. karaf-jdbc-example and karaf-rest-example?

The module name for the bundle providing the service implementation for the two examples mentioned above, ends with "-provider". Is this what I should use as well?

What about the webapi and webgui modules? Should I keep the names, but replace "." with "-"? Ie. karaf-jersey-example-webapi and karaf-jersey-example-webgui?

jbonofre · 2018-10-14T05:32:45Z

examples/karaf-jersey-example/karaf-jersey-example.servicedef/pom.xml

+    <description>This is an OSGi bundle defining beans and interfaces for OSGI services.</description>
+
+    <properties>
+        <Bundle-SymbolicName>org.apache.karaf.examples.jersey.servicedef</Bundle-SymbolicName>


This property doesn't seem to be use in the maven-bundle-plugin configuration.

It was supposed to be, unless I've messed up something, and I think I verified what the actual symbolic name was.

The parent POM defines BundleSymbolicName to be, in properties:

<Bundle-SymbolicName>${project.groupId}.${project.artifactId}</Bundle-SymbolicName>

and also inside the maven-bundle-plugin config (on line 301 in the top POM in my version):

<instructions> <Bundle-SymbolicName>${Bundle-SymbolicName}</Bundle-SymbolicName>

However, when I put "-" into the artifactId I could no longer use that approach. Also the groupId contained much of the same information as the long artifactId. So I put "overrides" in each bundle project to get a sensible symbolic name, such as eg. the example above.

I've just checked the manifest.mf of the karaf-jersey-example.servicedef-4.2.2-SNAPSHOT.jar file in my build, and it contains

Bundle-SymbolicName: org.apache.karaf.examples.jersey.servicedef

(which is the setting from the properties you quote)

jbonofre · 2018-10-14T05:33:59Z

...xample.servicedef/src/main/java/org/apache/karaf/examples/jersey/servicedef/beans/Count.java

+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+package org.apache.karaf.examples.jersey.servicedef.beans;


No need to put in beans. The POJO used by the service can be at the same service definition level aka org.apache.karaf.examples.jersey.service.

I've used org.apache.karaf.examples.jersey.services for the package containing the service implementation, and org.apache.karaf.examples.jersey.servicedef for the service implementation (which also has a match in part of the artifactId, the module name and bundle-symbolic-name).

Is it OK to keep this?

Or will the service definition package need to be changed to org.apache.karaf.examples.jersey.service and the implementation package need to be changed to something else?

jbonofre · 2018-10-14T05:34:58Z

...example.services/src/main/java/org/apache/karaf/examples/jersey/services/CounterService.java

+import org.apache.karaf.examples.jersey.servicedef.beans.Count;
+import org.osgi.service.component.annotations.Component;
+
+@Component(service={Counter.class})


That's implicit with SCR, @Component is enough.

jbonofre · 2018-10-14T05:36:55Z

retest this please

jbonofre · 2018-10-22T05:48:23Z

I'm doing a new pass, probably upgrade features XML.

jbonofre · 2018-10-31T05:36:25Z

Sorry for the delay in the review, I'm in vacation but I will do a new pass.

steinarb · 2018-10-31T05:58:45Z

If you want to, I can do the suggested changes and update the PR branch?

jbonofre · 2018-10-31T09:23:50Z

Yeah, I will provide all feedback to be consistent with the other examples.

jbonofre · 2020-10-02T03:38:49Z

Old PR cleanup

Add an example of using Jersey in karaf

e775776

jbonofre self-requested a review October 11, 2018 07:38

Add ASF copyright headers to files that were missing them

d2c9c21

steinarb force-pushed the add-karaf-jersey-example branch from f80cacb to d2c9c21 Compare October 12, 2018 19:21

Replace old copyright headers with the ASF copyright headers

9be272a

jbonofre approved these changes Oct 14, 2018

View reviewed changes

jbonofre closed this Oct 2, 2020

Add an example of using Jersey in karaf #633

Add an example of using Jersey in karaf #633

Uh oh!

Conversation

steinarb commented Oct 10, 2018

Uh oh!

steinarb commented Oct 11, 2018

Uh oh!

jbonofre commented Oct 11, 2018

Uh oh!

steinarb commented Oct 12, 2018

Uh oh!

fpapon commented Oct 12, 2018

Uh oh!

steinarb commented Oct 12, 2018

Uh oh!

steinarb commented Oct 12, 2018

Uh oh!

jbonofre commented Oct 13, 2018

Uh oh!

jbonofre left a comment

Choose a reason for hiding this comment

Uh oh!

jbonofre Oct 14, 2018

Choose a reason for hiding this comment

Uh oh!

steinarb Nov 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jbonofre Oct 14, 2018

Choose a reason for hiding this comment

Uh oh!

steinarb Oct 14, 2018

Choose a reason for hiding this comment

Uh oh!

jbonofre Oct 14, 2018

Choose a reason for hiding this comment

Uh oh!

steinarb Nov 1, 2018

Choose a reason for hiding this comment

Uh oh!

jbonofre Oct 14, 2018

Choose a reason for hiding this comment

Uh oh!

jbonofre commented Oct 14, 2018

Uh oh!

jbonofre commented Oct 22, 2018

Uh oh!

jbonofre commented Oct 31, 2018

Uh oh!

steinarb commented Oct 31, 2018

Uh oh!

jbonofre commented Oct 31, 2018

Uh oh!

jbonofre commented Oct 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

steinarb Nov 1, 2018 •

edited

Loading