[KARAF-6125] Standardized timezone handling for audit dates#747
Merged
jbonofre merged 1 commit intoapache:masterfrom Feb 1, 2019
Merged
[KARAF-6125] Standardized timezone handling for audit dates#747jbonofre merged 1 commit intoapache:masterfrom
jbonofre merged 1 commit intoapache:masterfrom
Conversation
Fixed a couple of cases where the FastDateFormat was not using a consistent timezone (sometimes provided and sometimes the default). This also required fixing a couple of callers of the FastDateFormat, which was mostly related to tests. This bug caused audit file names to sometimes incorrectly roll between days depending on the timezone of the user.
jbonofre
approved these changes
Jan 31, 2019
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot ! I'm including this for Karaf 4.2.3.
Member
|
retest this please |
Member
|
The test failure is not related to the PR (it's a flaky test). I launch a new Jenkins to double check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a couple of cases where the FastDateFormat was not using a consistent timezone (sometimes provided and sometimes the default). This also required fixing a couple of callers of the FastDateFormat, which was mostly related to tests.
This bug caused audit file names to sometimes incorrectly roll between days depending on the timezone of the user.