KARAF-6220, add principal info to file and log audit logs#802
Merged
jbonofre merged 1 commit intoapache:masterfrom Apr 5, 2019
sjhiggs:KARAF-6220
Merged
KARAF-6220, add principal info to file and log audit logs#802jbonofre merged 1 commit intoapache:masterfrom sjhiggs:KARAF-6220
jbonofre merged 1 commit intoapache:masterfrom
sjhiggs:KARAF-6220
Conversation
oscerd
approved these changes
Apr 1, 2019
jbonofre
requested changes
Apr 1, 2019
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
Overall good. Thanks ! Can you please change the commit message to use "[KARAF-6220] Add principal info to file and log audit logs" ?
Contributor
|
Looks good, thanks @sjhiggs. I'd only complain about: if(principalInfos.size() > 0) {(lack of space between |
Contributor
Author
|
thanks @grgrzybek, fixed. |
jbonofre
requested changes
Apr 1, 2019
.../modules/src/test/java/org/apache/karaf/jaas/modules/audit/AbstractAuditLoginModuleTest.java
Show resolved
Hide resolved
jbonofre
approved these changes
Apr 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.