KARAF-6350 - Add support for elliptic keys in the PublicKeyLoginModule#896
Merged
jbonofre merged 1 commit intoapache:masterfrom Jul 2, 2019
coheigea:publickey_jaas
Merged
KARAF-6350 - Add support for elliptic keys in the PublicKeyLoginModule#896jbonofre merged 1 commit intoapache:masterfrom coheigea:publickey_jaas
jbonofre merged 1 commit intoapache:masterfrom
coheigea:publickey_jaas
Conversation
Contributor
Author
|
@jbonofre Done |
jbonofre
approved these changes
Jul 2, 2019
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
LGTM, thanks ! Waiting Jenkins before merging.
Member
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This involves flipping the logic in PublicKeyLoginModule. Instead of converting the client key to a String + comparing it to the String in keys.properties, it takes the String in keys.properties and converts it into a Public Key. It's easier doing this for elliptic curve keys, as the encoding rules are pretty complex. I also added a bunch of tests.