[KARAF-6351] Handle package-less classes#899
Merged
skitt merged 1 commit intoapache:masterfrom Aug 8, 2019
Merged
Conversation
The classes command unconditionnally tries to extract a package name, which fails with classes which don't have one. This patch checks for the presence of "/" before attempting to use it as a delimiter. Classes with no package are assumed to not be exported. Signed-off-by: Stephen Kitt <skitt@redhat.com>
oscerd
approved these changes
Aug 3, 2019
Member
|
I didn't validate the review (sorry I'm in vacation this week). |
Member
Author
Ah, sorry, do you want me to revert? |
Member
|
@skitt no, it's OK, no problem, I hope it's OK (I saw an issue in a previous PR/commit not reviewed who broke the password encryption, that's why it's important to have a four eyes validation). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The classes command unconditionnally tries to extract a package name,
which fails with classes which don't have one. This patch checks for
the presence of "/" before attempting to use it as a delimiter.
Classes with no package are assumed to not be exported.
Signed-off-by: Stephen Kitt skitt@redhat.com