Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ karaf.framework.felix=mvn\:org.apache.felix/org.apache.felix.framework/@@felix.f
# Framework config properties.
#
org.osgi.framework.system.packages= \
org.osgi.dto;version="1.0",\
org.osgi.dto;version="1.1",\
org.osgi.resource;version="1.0",\
org.osgi.resource.dto;version="1.0";uses:="org.osgi.dto",\
org.osgi.framework;version="1.8",\
org.osgi.framework.dto;version="1.8";uses:="org.osgi.dto",\
org.osgi.framework;version="1.9",\
org.osgi.framework.dto;version="1.9";uses:="org.osgi.dto",\
org.osgi.framework.hooks.bundle;version="1.1";uses:="org.osgi.framework",\
org.osgi.framework.hooks.resolver;version="1.0";uses:="org.osgi.framework.wiring",\
org.osgi.framework.hooks.service;version="1.1";uses:="org.osgi.framework",\
Expand All @@ -71,13 +71,13 @@ org.osgi.framework.system.packages= \
org.osgi.framework.startlevel;version="1.0";uses:="org.osgi.framework",\
org.osgi.framework.startlevel.dto;version="1.0";uses:="org.osgi.dto",\
org.osgi.framework.wiring;version="1.2";uses:="org.osgi.framework,org.osgi.resource",\
org.osgi.framework.wiring.dto;version="1.2";uses:="org.osgi.dto,org.osgi.resource.dto",\
org.osgi.framework.wiring.dto;version="1.3";uses:="org.osgi.dto,org.osgi.resource.dto",\
org.osgi.service.condpermadmin;version="1.1.1";uses:="org.osgi.framework,org.osgi.service.permissionadmin",\
org.osgi.service.packageadmin;version="1.2";uses:="org.osgi.framework",org.osgi.service.permissionadmin;version="1.2",\
org.osgi.service.resolver;version="1.0";uses:="org.osgi.resource",\
org.osgi.service.resolver;version="1.1";uses:="org.osgi.resource",\
org.osgi.service.startlevel;version="1.1";uses:="org.osgi.framework",\
org.osgi.service.url;version="1.0",\
org.osgi.util.tracker;version="1.5.1";uses:="org.osgi.framework",\
org.osgi.util.tracker;version="1.5.2";uses:="org.osgi.framework",\
org.apache.karaf.version;version="@@karaf.osgi.version@@",\
org.apache.karaf.jaas.boot.principal;uses:=javax.security.auth;version="@@karaf.osgi.version@@",\
org.apache.karaf.jaas.boot;uses:="javax.security.auth,javax.security.auth.callback,javax.security.auth.login,javax.security.auth.spi,org.osgi.framework";version="@@karaf.osgi.version@@",\
Expand Down
2 changes: 1 addition & 1 deletion assemblies/features/static/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
</dependency>
<dependency>
<groupId>org.ops4j.pax.logging</groupId>
<artifactId>pax-logging-service</artifactId>
<artifactId>pax-logging-log4j1</artifactId>
</dependency>
<dependency>
<groupId>org.apache.karaf.services</groupId>
Expand Down
1 change: 1 addition & 0 deletions audit/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@
<Export-Package>
</Export-Package>
<Import-Package>
org.osgi.framework;version="[1,3)",
*
</Import-Package>
<Private-Package>
Expand Down
4 changes: 4 additions & 0 deletions bundle/core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@
<Export-Package>
org.apache.karaf.bundle.core;-noimport:=true
</Export-Package>
<Import-Package>
org.osgi.framework;version="[1,3)",
*
</Import-Package>
<Private-Package>
org.apache.karaf.bundle.command*,
org.apache.karaf.bundle.core.internal,
Expand Down
1 change: 1 addition & 0 deletions config/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
</Export-Package>
<Import-Package>
org.osgi.service.metatype;resolution:=optional,
org.osgi.framework;version="[1,3)",
*
</Import-Package>
<Private-Package>
Expand Down
4 changes: 4 additions & 0 deletions deployer/features/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,10 @@
<configuration>
<instructions>
<Export-Package />
<Import-Package>
org.osgi.framework;version="[1,3)",
*
</Import-Package>
<Private-Package>
org.apache.karaf.deployer.features,
org.apache.karaf.deployer.features.osgi,
Expand Down
1 change: 1 addition & 0 deletions diagnostic/boot/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
<Import-Package>
com.sun.management;resolution:=optional,
sun.misc;resolution:=optional,
org.osgi.framework;version="[1,3)",
*
</Import-Package>
<Karaf-Activator>
Expand Down
1 change: 1 addition & 0 deletions diagnostic/core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@
</Export-Package>
<Import-Package>
com.sun.management*;resolution:=optional,
org.osgi.framework;version="[1,3)",
*
</Import-Package>
<Private-Package>
Expand Down
1 change: 1 addition & 0 deletions docker/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@
</Export-Package>
<Import-Package>
com.fasterxml.jackson*;version="[2,3)",
org.osgi.framework;version="[1,3)",
*
</Import-Package>
<Private-Package>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
<dependencies>
<dependency>
<groupId>org.ops4j.pax.logging</groupId>
<artifactId>pax-logging-service</artifactId>
<artifactId>pax-logging-log4j1</artifactId>
</dependency>
<dependency>
<groupId>org.osgi</groupId>
Expand All @@ -52,7 +52,7 @@
<configuration>
<instructions>
<Import-Package>
org.ops4j.pax.logging*;version="[1.7,2)",
org.ops4j.pax.logging*;version="[1,3)",
*
</Import-Package>
</instructions>
Expand Down
2 changes: 2 additions & 0 deletions features/core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@
<Import-Package>
!org.eclipse.osgi.service.resolver,
javax.xml.bind*;version="[2.2,3)",
org.osgi.framework*;version="[1,3)",
org.osgi.service.resolver;version="[1,3)",
*
</Import-Package>
<Private-Package>
Expand Down
4 changes: 4 additions & 0 deletions http/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@
<Export-Package>
org.apache.karaf.http.core
</Export-Package>
<Import-Package>
org.osgi.framework;version="[1,3)",
*
</Import-Package>
<Private-Package>
org.apache.karaf.util.tracker;-split-package:=merge-first,
org.apache.karaf.http.command,
Expand Down
1 change: 1 addition & 0 deletions instance/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@
<Import-Package>
!org.apache.karaf.shell.impl.action.command,
!org.apache.karaf.instance.core.internal,
org.osgi.framework;version="[1,3)",
*
</Import-Package>
<Private-Package>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ karaf.framework.felix=mvn\:org.apache.felix/org.apache.felix.framework/@@felix.f
# Framework config properties.
#
org.osgi.framework.system.packages= \
org.osgi.dto;version="1.0",\
org.osgi.dto;version="1.1",\
org.osgi.resource;version="1.0",\
org.osgi.resource.dto;version="1.0";uses:="org.osgi.dto",\
org.osgi.framework;version="1.8",\
org.osgi.framework.dto;version="1.8";uses:="org.osgi.dto",\
org.osgi.framework;version="1.9",\
org.osgi.framework.dto;version="1.9";uses:="org.osgi.dto",\
org.osgi.framework.hooks.bundle;version="1.1";uses:="org.osgi.framework",\
org.osgi.framework.hooks.resolver;version="1.0";uses:="org.osgi.framework.wiring",\
org.osgi.framework.hooks.service;version="1.1";uses:="org.osgi.framework",\
Expand All @@ -71,13 +71,13 @@ org.osgi.framework.system.packages= \
org.osgi.framework.startlevel;version="1.0";uses:="org.osgi.framework",\
org.osgi.framework.startlevel.dto;version="1.0";uses:="org.osgi.dto",\
org.osgi.framework.wiring;version="1.2";uses:="org.osgi.framework,org.osgi.resource",\
org.osgi.framework.wiring.dto;version="1.2";uses:="org.osgi.dto,org.osgi.resource.dto",\
org.osgi.framework.wiring.dto;version="1.3";uses:="org.osgi.dto,org.osgi.resource.dto",\
org.osgi.service.condpermadmin;version="1.1.1";uses:="org.osgi.framework,org.osgi.service.permissionadmin",\
org.osgi.service.packageadmin;version="1.2";uses:="org.osgi.framework",org.osgi.service.permissionadmin;version="1.2",\
org.osgi.service.resolver;version="1.0";uses:="org.osgi.resource",\
org.osgi.service.resolver;version="1.1";uses:="org.osgi.resource",\
org.osgi.service.startlevel;version="1.1";uses:="org.osgi.framework",\
org.osgi.service.url;version="1.0",\
org.osgi.util.tracker;version="1.5.1";uses:="org.osgi.framework",\
org.osgi.util.tracker;version="1.5.2";uses:="org.osgi.framework",\
org.apache.karaf.version;version="@@karaf.osgi.version@@",\
org.apache.karaf.jaas.boot.principal;uses:=javax.security.auth;version="@@karaf.osgi.version@@",\
org.apache.karaf.jaas.boot;uses:="javax.security.auth,javax.security.auth.callback,javax.security.auth.login,javax.security.auth.spi,org.osgi.framework";version="@@karaf.osgi.version@@",\
Expand Down
12 changes: 6 additions & 6 deletions itests/test/src/test/filtered-resources/etc/config.properties
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ karaf.framework.felix=mvn\:org.apache.felix/org.apache.felix.framework/@@felix.f
# Framework config properties.
#
org.osgi.framework.system.packages= \
org.osgi.dto;version="1.0",\
org.osgi.dto;version="1.1",\
org.osgi.resource;version="1.0",\
org.osgi.resource.dto;version="1.0";uses:="org.osgi.dto",\
org.osgi.framework;version="1.8",\
org.osgi.framework.dto;version="1.8";uses:="org.osgi.dto",\
org.osgi.framework;version="1.9",\
org.osgi.framework.dto;version="1.9";uses:="org.osgi.dto",\
org.osgi.framework.hooks.bundle;version="1.1";uses:="org.osgi.framework",\
org.osgi.framework.hooks.resolver;version="1.0";uses:="org.osgi.framework.wiring",\
org.osgi.framework.hooks.service;version="1.1";uses:="org.osgi.framework",\
Expand All @@ -71,13 +71,13 @@ org.osgi.framework.system.packages= \
org.osgi.framework.startlevel;version="1.0";uses:="org.osgi.framework",\
org.osgi.framework.startlevel.dto;version="1.0";uses:="org.osgi.dto",\
org.osgi.framework.wiring;version="1.2";uses:="org.osgi.framework,org.osgi.resource",\
org.osgi.framework.wiring.dto;version="1.2";uses:="org.osgi.dto,org.osgi.resource.dto",\
org.osgi.framework.wiring.dto;version="1.3";uses:="org.osgi.dto,org.osgi.resource.dto",\
org.osgi.service.condpermadmin;version="1.1.1";uses:="org.osgi.framework,org.osgi.service.permissionadmin",\
org.osgi.service.packageadmin;version="1.2";uses:="org.osgi.framework",org.osgi.service.permissionadmin;version="1.2",\
org.osgi.service.resolver;version="1.0";uses:="org.osgi.resource",\
org.osgi.service.resolver;version="1.1";uses:="org.osgi.resource",\
org.osgi.service.startlevel;version="1.1";uses:="org.osgi.framework",\
org.osgi.service.url;version="1.0",\
org.osgi.util.tracker;version="1.5.1";uses:="org.osgi.framework",\
org.osgi.util.tracker;version="1.5.2";uses:="org.osgi.framework",\
org.apache.karaf.version;version="@@karaf.osgi.version@@",\
org.apache.karaf.jaas.boot.principal;uses:=javax.security.auth;version="@@karaf.osgi.version@@",\
org.apache.karaf.jaas.boot;uses:="javax.security.auth,javax.security.auth.callback,javax.security.auth.login,javax.security.auth.spi,org.osgi.framework";version="@@karaf.osgi.version@@",\
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,6 @@ public void checkInstalledFeaturesBoot() throws Exception {
assertFeatureInstalled("service");
assertFeatureInstalled("system");
}

@Test
public void installFrameworkSecurityFeature() throws Exception {
installAssertAndUninstallFeatures("framework-security");
}

public void installServiceSecurityFeature() throws Exception {
System.out.println("===>installServiceSecurityFeature");
Expand Down
1 change: 1 addition & 0 deletions jaas/config/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
</Export-Package>
<Import-Package>
!${project.artifactId}.*,
org.osgi.framework;version="[1,3)",
*
</Import-Package>
<Private-Package>
Expand Down
1 change: 1 addition & 0 deletions jaas/jasypt/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@
<configuration>
<instructions>
<Import-Package>
org.osgi.framework;version="[1,3)",
*
</Import-Package>
<Private-Package>
Expand Down
1 change: 1 addition & 0 deletions jaas/modules/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@
javax.net,
org.apache.karaf.jaas.config,
org.osgi.service.event;resolution:=optional,
org.osgi.framework;version="[1,3)",
!net.sf.ehcache*,
!net.spy.memcached*,
com.sun.security.auth.module;resolution:=optional,
Expand Down
4 changes: 4 additions & 0 deletions jdbc/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@
<Export-Package>
org.apache.karaf.jdbc
</Export-Package>
<Import-Package>
org.osgi.framework;version="[1,3)",
*
</Import-Package>
<Private-Package>
org.apache.karaf.jdbc.command,
org.apache.karaf.jdbc.command.ds,
Expand Down
1 change: 1 addition & 0 deletions jms/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@
<Import-Package>
javax.jms;version="[1.1,3)",
org.apache.activemq*;resolution:=optional,
org.osgi.framework;version="[1,3)",
*
</Import-Package>
<Private-Package>
Expand Down
4 changes: 4 additions & 0 deletions jndi/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@
<Export-Package>
org.apache.karaf.jndi
</Export-Package>
<Import-Package>
org.osgi.framework;version="[1,3)",
*
</Import-Package>
<Private-Package>
org.apache.karaf.jndi.command,
org.apache.karaf.jndi.command.completers,
Expand Down
4 changes: 4 additions & 0 deletions kar/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@
<Export-Package>
org.apache.karaf.kar
</Export-Package>
<Import-Package>
org.osgi.framework;version="[1,3)",
*
</Import-Package>
<Private-Package>
org.apache.karaf.kar.command,
org.apache.karaf.kar.command.completers,
Expand Down
1 change: 1 addition & 0 deletions log/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@
org.apache.karaf.log.core
</Export-Package>
<Import-Package>
org.osgi.framework;version="[1,3)",
*
</Import-Package>
<Private-Package>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,18 @@
import org.apache.karaf.log.core.internal.layout.PatternConverter;
import org.apache.karaf.log.core.internal.layout.PatternParser;
import org.ops4j.pax.logging.spi.PaxLoggingEvent;
import org.osgi.service.log.LogLevel;

public class LogEventFormatterImpl implements LogEventFormatter {

private String pattern;
private Map<Integer, String> level2Color = new HashMap<>();
private Map<LogLevel, String> level2Color = new HashMap<>();

public void setPattern(String pattern) {
this.pattern = pattern;
}

public void setColor(int level, String color) {
public void setColor(LogLevel level, String color) {
if (color != null && color.length() > 0) {
this.level2Color.put(level, color);
} else {
Expand Down Expand Up @@ -73,7 +74,7 @@ private void color(StringBuffer sb, String color) {

private String getColor(PaxLoggingEvent event, boolean noColor) {
if (!noColor && event != null && event.getLevel() != null && event.getLevel().toString() != null) {
return level2Color.get(event.getLevel().toInt());
return level2Color.get(event.getLevel());
} else {
return null;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import org.ops4j.pax.logging.PaxLogger;
import org.ops4j.pax.logging.spi.PaxLocationInfo;
import org.ops4j.pax.logging.spi.PaxLoggingEvent;
import org.osgi.service.log.LogLevel;

/**
* Copied from log4j
Expand Down Expand Up @@ -559,22 +560,20 @@ private String createSequence(String... names) {
public
String convert(PaxLoggingEvent event) {
String s;
switch (event.getLevel().toInt()) {
case PaxLogger.LEVEL_TRACE:
s = "trace";
break;
case PaxLogger.LEVEL_DEBUG:
s = "debug";
break;
case PaxLogger.LEVEL_INFO:
s = "info";
break;
case PaxLogger.LEVEL_WARNING:
s = "warn";
break;
default:
s = "error";
break;
if (event.getLevel().toLevel().equals(LogLevel.TRACE)) {
s = "trace";
} else if (event.getLevel().toLevel().equals(LogLevel.DEBUG)) {
s = "debug";
} else if (event.getLevel().toLevel().equals(LogLevel.INFO)) {
s = "info";
} else if (event.getLevel().toLevel().equals(LogLevel.WARN)) {
s = "warn";
} else if (event.getLevel().toLevel().equals(LogLevel.ERROR)) {
s = "error";
} else if (event.getLevel().toLevel().equals(LogLevel.AUDIT)) {
s = "audit";
} else {
s = "error";
}
String str = style.get(s);
if (str != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import org.ops4j.pax.logging.spi.PaxAppender;
import org.osgi.service.cm.ConfigurationAdmin;
import org.osgi.service.cm.ManagedService;
import org.osgi.service.log.LogLevel;

@Services(
requires = @RequireService(ConfigurationAdmin.class),
Expand All @@ -56,11 +57,12 @@ protected void doStart() throws Exception {

LogEventFormatterImpl formatter = new LogEventFormatterImpl();
formatter.setPattern(pattern);
formatter.setColor(PaxLogger.LEVEL_ERROR, errorColor);
formatter.setColor(PaxLogger.LEVEL_WARNING, warnColor);
formatter.setColor(PaxLogger.LEVEL_INFO, infoColor);
formatter.setColor(PaxLogger.LEVEL_DEBUG, debugColor);
formatter.setColor(PaxLogger.LEVEL_TRACE, traceColor);
formatter.setColor(LogLevel.ERROR, errorColor);
formatter.setColor(LogLevel.WARN, warnColor);
formatter.setColor(LogLevel.INFO, infoColor);
formatter.setColor(LogLevel.DEBUG, debugColor);
formatter.setColor(LogLevel.TRACE, traceColor);
formatter.setColor(LogLevel.AUDIT, traceColor);
register(LogEventFormatter.class, formatter);

LogServiceImpl logService = new LogServiceImpl(configurationAdmin, size);
Expand Down
Loading