Skip to content

Conversation

@bonampak
Copy link
Contributor

KNOX-3189 - Updated slf4j version to 2.0.13 and log4j2 version to 2.20.0.

What changes were proposed in this pull request?

As org.apache.logging.log4j:log4j-slf4j-impl (bridge between SLF4J 1.x and log4j2) needs to be replaced with org.apache.logging.log4j:log4j-slf4j2-impl (bridge between SLF4J 2.x and log4j2), the log4j2 version also needed to be updated (the first available version would have been 2.19.0; for log4j2 2.17.1, the bridge artifact for SLF4J2 does not exist, as slf4j2.x did not exist then).

How was this patch tested?

Inspecting maven dependency tree.
org.slf4j:slf4j-api:jar:2.0.13
org.slf4j:jcl-over-slf4j:jar:2.0.13
org.apache.logging.log4j:log4j-slf4j2-impl:jar:2.20.0

Running manual tests with different log4j configurations using KNOX_GATEWAY_LOG_OPTS in knox-env.sh.
Changing log4j2.debug to true, Configuration status levels, root logger and package-level logs.

Note:

  • in our dependency tree, we still have an org.slf4j:slf4j-reload4j:jar:1.7.36:provided from org.apache.hadoop:hadoop-mapreduce-client-core, but that is not a problem as it's not part of our dep release folder.
  • ch.qos.reload4j:reload4j:jar:1.2.22 is still there in hadoop-common, but probably we should exclude that as well.

Copy link
Contributor

@smolnar82 smolnar82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smolnar82 smolnar82 merged commit eb474ad into apache:master Oct 20, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants