Skip to content

KNOX-3197: Upgrade homepage UI to node 22, angular 20+ ang bootstrap … #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hanicz merged 3 commits into from
Dec 3, 2025
Merged

KNOX-3197: Upgrade homepage UI to node 22, angular 20+ ang bootstrap … #1104

hanicz merged 3 commits into from
Dec 3, 2025

Conversation

@hanicz
Copy link
Contributor

@hanicz hanicz commented Oct 31, 2025 •
edited
Loading

…to 5+

KNOX-3197 - Upgrade homepage UI node, angular and bootstrap

What changes were proposed in this pull request?

  • Upgrades the Homepage UI to bootstrap 5+, angular 20+ and node to v22.20, rxjs to 7.8.2, sweetalert to 11.26.3, core-js to 3.46.0
  • Restructured the project
  • Replaced old bs-modals with components
  • Replaced old toPromise calls with firstValueFrom

How was this patch tested?

rm -rf package-lock.json node_modules/
npm install

Manually tested locally with mocked json-server data and also with a running Knox.

image Screenshot 2025-12-03 at 13 27 39 Screenshot 2025-12-03 at 13 28 25 Screenshot 2025-12-03 at 13 28 38 Screenshot 2025-12-03 at 13 28 49 Screenshot 2025-12-03 at 13 29 22

@hanicz hanicz self-assigned this Oct 31, 2025
@hanicz hanicz marked this pull request as ready for review November 3, 2025 12:37
smolnar82
smolnar82 approved these changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@smolnar82 smolnar82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I deployed my local Knox with these changes and validated them. This is a cool improvement, thanks @hanicz for taking care of this!

@hanicz hanicz merged commit f7815da into apache:master Dec 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smolnar82 smolnar82 smolnar82 approved these changes

@moresandeep moresandeep Awaiting requested review from moresandeep

@pzampino pzampino Awaiting requested review from pzampino

@bonampak bonampak Awaiting requested review from bonampak

Assignees

@hanicz hanicz

Labels

homepage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hanicz @smolnar82