KNOX-1919 - Taking gateway.path into consideration when processing redirectToUrl provider param with the OOTB knoxsso.xml sample#113
Merged
risdenk merged 1 commit intoapache:masterfrom Jul 10, 2019
Conversation
…directToUrl provider param with the OOTB knoxsso.xml sample
Contributor
Author
|
@risdenk @pzampino @moresandeep - please review my changes! Thanks! |
risdenk
approved these changes
Jul 10, 2019
Contributor
Author
|
@risdenk - could you please re-trigger the Travis job; the error is unrelated to my change. Thanks! |
Contributor
|
yup kicked the one build off again :) |
twmarshall
pushed a commit
to twmarshall/knox
that referenced
this pull request
Aug 27, 2019
…ocessing redirectToUrl provider param with the OOTB knoxsso.xml sample (apache#113) Change-Id: I4c806abc980ab886240a852f79d1bb06192a2169
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
…ocessing redirectToUrl provider param with the OOTB knoxsso.xml sample (apache#113) Change-Id: I4c806abc980ab886240a852f79d1bb06192a2169
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Before my change, the
redirectToUrlparameter in the OOTBknoxsso.xmltopology was hardcoded to/gateway/knoxsso/knoxauth/login.html. In case we changed thegateway.pathconfiguration element the admin UI became unreachable. If you knew where to find the root cause it was easy to fix it, but we can do this smarter.I changed the sample URL to
/${GATEWAY_PATH}/knoxsso/knoxauth/login.htmland made sure to replace the${GATEWAY_PATH}placeholder with the actual value ofgateway.path.How was this patch tested?
Tested manually as follows:
gateway.pathtosmolnar_testingateway-site.xmlhttps://localhost:8443/smolnar_test/manager/admin-ui/