KNOX-3361: Route OpenSAML off BouncyCastle in FIPS mode#1299
Open
hanicz wants to merge 1 commit into
Open
Conversation
Test Results32 tests 32 ✅ 3s ⏱️ Results for commit af4ec7c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3361 - Route OpenSAML off BouncyCastle in FIPS mode
What changes were proposed in this pull request?
New
gateway-shim-opensaml-security-apimodule: a shaded drop-in fororg.opensaml:opensaml-security-apithat swaps upstream's GlobalNamedCurveRegistryInitializer for a Knox-owned wrapper. When Knox is running on a FIPS cluster, the wrapper short-circuits SPI-driven EC curve registration soAbstractNamedCurve.initialize()never invokesorg.bouncycastle.jce.ECNamedCurveTable— preventing BouncyCastle EC code from executing. In non-FIPS deployments the wrapper delegates to the upstream initializer, preserving unmodified OpenSAML behavior.ECDH-ES-encrypted SAML assertion decryption is not supported in FIPS mode (empty NamedCurveRegistry). RSA-signed and RSA-OAEP-encrypted SAML flows work identically in FIPS and non-FIPS.
This solution builds on what elasticsearch did, however for Knox it acts based on being on FIPS cluster or not.
How was this patch tested?
KnoxNamedCurveRegistryInitializerTestcovers both branches:FIPS mode → registry empty,
ECSupport.getNamedCurvereturns nullNon-FIPS mode → registry populated by upstream,
ECSupport.getNamedCurveresolvessecp256r1Integration Tests
N/A
UI changes
N/A