KNOX-2013 - CM discovery - Add Phoenix to auto discovery#148
Merged
risdenk merged 1 commit intoapache:masterfrom Sep 23, 2019
Merged
KNOX-2013 - CM discovery - Add Phoenix to auto discovery#148risdenk merged 1 commit intoapache:masterfrom
risdenk merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
FYI @pzampino |
smolnar82
reviewed
Sep 23, 2019
Contributor
smolnar82
left a comment
smolnar82
left a comment
There was a problem hiding this comment.
Could you please rebase your change (so that the build issue on Tavis should disappear) and submit a new patch?
...rg/apache/knox/gateway/topology/discovery/cm/model/phoenix/PhoenixServiceModelGenerator.java
Outdated
Show resolved
Hide resolved
Change-Id: Ib8af699e80dc124045e2b77cd3cce092d213512c
risdenk
approved these changes
Sep 23, 2019
risdenk
changed the title
Contributor
|
@stoty change looks good. Once Travis builds finish I'll merge it. Most likely later today. |
Contributor
|
+1 |
pzampino
approved these changes
Sep 23, 2019
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
…pache#148) Signed-off-by: Kevin Risden <krisden@cloudera.com> Change-Id: I2922d41d42510d3fbc53c9a597db581842508968
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
…covery (apache#148)" into cdpd-master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding a new module to CM discovery to automatically create AVATICA service that can be used to access the Phoenix Query Servers running in the cluster
How was this patch tested?
I have brought up a test cluster, added "AVATICA" to the list autoconfigured services, started autodiscovery, and checked that the default.xml topology file gets correctly generated.
I have also connected to the Phoenix Query Server via Knox.