KNOX-2026 - Accept Impala's authentication cookies#161
Merged
risdenk merged 1 commit intoapache:masterfrom Oct 9, 2019
Merged
Conversation
This patch modifies HadoopAuthCookieStore to accept cookies with Impala's cookie name, "impala.auth". It also updates a check that is used to ensure the cookie belongs to Knox - previously, this check parsed the cookie according to the specific format that Hadoop uses for its cookies and ensures that the Knox principal appears in the expected location. Impala uses a similar cookie format, but with a few changes such as fields being in a different order. The check is made more permissive such that it will accept any cookie that contains the Knox principal anywhere in it. Testing: - Deployed in a cluster and verified that Knox accepts and returns Impala's cookies as expected. Change-Id: Ib6c92b801a0182c8087f3f9e99c59f7311f2641b
Contributor
Author
|
@pzampino could you possible take a look? You appear to have implemented the check in the first place in KNOX-1341. Thanks |
risdenk
approved these changes
Oct 4, 2019
Contributor
|
Change looks good to me. Limited to only the 3 cookies that Knox will check anyway. Waiting on @pzampino to review as well |
pzampino
approved these changes
Oct 9, 2019
risdenk
changed the title
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
…e#161) This patch modifies HadoopAuthCookieStore to accept cookies with Impala's cookie name, "impala.auth". It also updates a check that is used to ensure the cookie belongs to Knox - previously, this check parsed the cookie according to the specific format that Hadoop uses for its cookies and ensures that the Knox principal appears in the expected location. Impala uses a similar cookie format, but with a few changes such as fields being in a different order. The check is made more permissive such that it will accept any cookie that contains the Knox principal anywhere in it. Testing: - Deployed in a cluster and verified that Knox accepts and returns Impala's cookies as expected. Signed-off-by: Kevin Risden <krisden@cloudera.com> Change-Id: Id366c2d54ad1da997d6b1f22d230e01ccdee6417
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch modifies HadoopAuthCookieStore to accept cookies with
Impala's cookie name, "impala.auth".
It also updates a check that is used to ensure the cookie belongs to
Knox - previously, this check parsed the cookie according to the
specific format that Hadoop uses for its cookies and ensures that the
Knox principal appears in the expected location.
Impala uses a similar cookie format, but with a few changes such as
fields being in a different order. The check is made more permissive
such that it will accept any cookie that contains the Knox principal
anywhere in it.
Testing:
Impala's cookies as expected.