KNOX-2121 - Zookeeper - Reduce amount of resources required to run tests #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our Zookeeper tests don't require 3 instances for them to run. We can instead use 1 instance and run the tests with fewer resources. The timeout for cluster starting up is determined by hostname lookup speed and can't easily be changed. https://github.com/apache/curator/blob/master/curator-test/src/main/java/org/apache/curator/test/TestingZooKeeperMain.java#L74 Signed-off-by: Kevin Risden <krisden@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Our Zookeeper tests don't require 3 instances
for them to run. We can instead use 1 instance
and run the tests with fewer resources.
The timeout for cluster starting up is determined
by hostname lookup speed and can't easily be changed.
https://github.com/apache/curator/blob/master/curator-test/src/main/java/org/apache/curator/test/TestingZooKeeperMain.java#L74
How was this patch tested?
mvn -T.75C verify -U -Ppackage,release -Dshellcheck