KNOX-2122 - Code cleanup from static code analysis #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risdenk
force-pushed
the
KNOX-2122
branch
2 times, most recently
from
888da27 to
db504da
Compare
* Diamond operator * Static method calls instead of on instances * Remove null check before instanceof * Use computeIfAbsent where possible * Remove simple nested if statements * Remove redundant cast * Use entrySet for iteration of maps Signed-off-by: Kevin Risden <krisden@apache.org>
Contributor
|
Let me know if you need another hand here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
mvn -T.75C verify -U -Ppackage,release -Dshellcheck