KNOX-2133 - Ensure that Knox always validates TLS#203
Merged
risdenk merged 1 commit intoapache:masterfrom Nov 22, 2019
Merged
Conversation
Signed-off-by: Kevin Risden <krisden@apache.org>
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
…#203) Signed-off-by: Kevin Risden <krisden@apache.org> Signed-off-by: Kevin Risden <krisden@cloudera.com> Change-Id: Iafa9fed53c0896687c51fcddff832dc4d26cfed5 Signed-off-by: Kevin Risden <krisden@cloudera.com>
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use forbiddenapis to block poor TLS usage. Note this could break some of the CLI stuff if using a self signed certificate. Fix the truststore instead :) The KnoxShell classes provide a way to properly setup the truststore.
How was this patch tested?
mvn -T.75C verify -Ppackage,release -Dshellcheck