KNOX-2156 - CM discovery - KUDUUI discovery#228
Merged
pzampino merged 1 commit intoapache:masterfrom Dec 20, 2019
Merged
Conversation
risdenk
approved these changes
Dec 20, 2019
| String scheme = sslEnabled ? "https" : "http"; | ||
|
|
||
| String port = getRoleConfigValue(roleConfig, "webserver_port"); | ||
| return createServiceModel(String.format(Locale.getDefault(), "%s://%s:%s/", scheme, hostname, port)); |
Contributor
There was a problem hiding this comment.
I'm not sure if this is in others and I missed it. I think Locale.ROOT is probably better here. I don't think we need to use localization for any of the parameters here. We should just plop in as is.
Note 99% sure we won't easily run into this since there are only a few locales where there is a differences.
Contributor
Author
There was a problem hiding this comment.
Local.getDefault() is used in the others. We can revisit that for all of them.
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
Change-Id: I0b89fd3a3966c8608d6c76c1669474169fa6b5b0
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
* changes: KNOX-2156 - CM discovery - KUDUUI discovery (apache#228) KNOX-2152 - Disable Ambari cluster configuration monitoring by default (apache#225) KNOX-2151 - HIVE_ON_TEZ HS2 Discovery doesn't work (apache#224) KNOX-1970 - CM discovery - Add Impala HS2 to auto discovery (apache#223)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added support for discovering URLs for the Apache Kudu UI.
How was this patch tested?
Added tests to ClouderaManagerServiceDiscoveryTest, and manually tested.