Skip to content

KNOX-2188 - Handling discovery details via advanced configuration#240

Merged
smolnar82 merged 1 commit intoapache:masterfrom
smolnar82:KNOX-2188
Jan 22, 2020
Merged

KNOX-2188 - Handling discovery details via advanced configuration#240
smolnar82 merged 1 commit intoapache:masterfrom
smolnar82:KNOX-2188

Conversation

@smolnar82
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Setting the following discovery details in a Knox descriptor, if they are not customized in the CM descriptors file:

  • discovery address
  • discovery cluster
  • discovery type

How was this patch tested?

Updated and executed JUnit tests:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:59 min (Wall Clock)
[INFO] Finished at: 2020-01-20T10:28:22+01:00
[INFO] Final Memory: 424M/1987M
[INFO] ------------------------------------------------------------------------

Copy link
Copy Markdown
Contributor

@lmccay lmccay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
+1

Copy link
Copy Markdown
Contributor

@moresandeep moresandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@smolnar82 smolnar82 merged commit 5bea67f into apache:master Jan 22, 2020
@smolnar82 smolnar82 deleted the KNOX-2188 branch January 22, 2020 06:28
lmccay added a commit that referenced this pull request Feb 8, 2020
…xShellTable (#258)

* KNOX-1742 - add to knoxshell usage rendering

* KNOX-2188 - Handling discovery details via advanced configuration (#240)

* KNOX-2190 - Processing advanced service discovery configuration on topology level (#242)

* KNOX-1742 - Fix javadoc warning

* KNOX-2196 - Upgrade caffeine to 2.8.1

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2197 - Upgrade dependency-check-maven to 5.3.0

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2198 - Upgrade groovy to 2.5.9

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2192 - Upgrade httpclient to 4.5.11

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2195 - Upgrade jetty to 9.4.26.v20200117

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2193 - Upgrade rest-assured to 4.2.0

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2199 - Upgrade spring-core to 5.2.3.RELEASE

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2194 - Upgrade spring-vault to 2.2.1.RELEASE

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2191 - Upgrade testcontainers to 1.12.5

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2200 - DefaultKeystoreService can lose entries under concurrent access (#243)

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2202 - Knox should use UTF-8 as default encoding instead of ISO-8859-1 (#244)

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2204 - KnoxLine NPE list datasources when directories don't exist (#246)

* KNOX-1742 - add to knoxshell usage rendering

* KNOX-2204 - KnoxLine NPE list datasources when directories don't exist

* KNOX-2203 - Upgrade admin-ui npm dependencies (#245)

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2208 - AclsAuthorizationFilter should log access at DEBUG level (#247)

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2153 - CM discovery - Monitor Cloudera Manager (#239)

* KNOX-2206 - Log exclusion of a discovered service due to configuration issues (#248)

* KNOX-2209 - Improve logging for Knox token handling (#250)

* KNOX-2217 - Upgrade apache pom to 23

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2219 - Upgrade checkstyle to 8.29

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2218 - Upgrade easymock to 4.2

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2220 - Upgrade nimbus-jose-jwt to 8.5

Signed-off-by: Kevin Risden <krisden@apache.org>

* KNOX-2213 - Service Discovery Support for CM UI, API (#249)

* KNOX-2215 - Token service should return a 403 response when the renewer is not white-listed (#251)

* KNOX-2224 - KnoxLine and KnoxShell DataSource and Select Command Alignment (#255)

* KNOX-1742 - add to knoxshell usage rendering

* KNOX-2204 - KnoxLine NPE list datasources when directories don't exist

* KNOX-2224 - KnoxLine and KnoxShell DataSource and Select Command Alignment

Change-Id: I55aef2dd7617baf10c5f9eb7706f61436aa3ad7d

* KNOX-2227 - Strip Leading and Trailing Whitespace from Headers in KnoxShellTable

Change-Id: I7778becab1ffe779350dbdd15472d308fa165f5f

* KNOX-2227 - switch to trim() for java 8

Change-Id: I9b8ba618c13de6bff0edb5c7d318cd28c251fa20

Co-authored-by: Sandor Molnar <smolnar@apache.org>
Co-authored-by: Kevin Risden <risdenk@users.noreply.github.com>
Co-authored-by: Phil Zampino <pzampino@apache.org>
Co-authored-by: Sandeep Moré <moresandeep@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants