Skip to content

KNOX-2289 - Passing GatewayServer.getGatewayServices() to SimpleDescriptorHandler.handle() as it needs it to provision encryption query string password#288

Merged
smolnar82 merged 1 commit intoapache:masterfrom
smolnar82:KNOX-2289
Mar 12, 2020

Conversation

@smolnar82
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

Manually tested:

  • redeployed Knox with my changes
  • had a CM descriptor with two topologies: topology1 and topology2
  • started Knox: the CM descriptor got picked up and generated into toplogies
  • confirmed that:
    • the previous ERROR message - Failed to create a password for query string encryption for - did not show up in the log
    • the password was created
$ bin/knoxcli.sh list-alias --cluster topology2
Listing aliases for: topology2
encryptquerystring

1 items.

$ bin/knoxcli.sh list-alias --cluster topology1
Listing aliases for: topology1
encryptquerystring

1 items.

@smolnar82 smolnar82 requested a review from pzampino March 11, 2020 20:55
@smolnar82 smolnar82 self-assigned this Mar 11, 2020
@smolnar82 smolnar82 requested a review from risdenk March 11, 2020 20:55
@risdenk
Copy link
Copy Markdown
Contributor

risdenk commented Mar 11, 2020

Ha that explains something that I don't have to track down now:

2020-03-03 21:17:42,936 ERROR topology.simple (SimpleDescriptorHandler.java:handle(176)) - Failed to create a password for query string encryption for cdp-proxy-api.

…iptorHandler.handle() as it needs it to provision encryption query string password
@smolnar82
Copy link
Copy Markdown
Contributor Author

I'd to rebase locally and submit a new PS due to changes in #287 (classes were re-factored out from DefaultTopologyService).

@smolnar82 smolnar82 merged commit 58d8479 into apache:master Mar 12, 2020
@smolnar82 smolnar82 deleted the KNOX-2289 branch March 12, 2020 16:59
stoty pushed a commit to stoty/knox that referenced this pull request May 14, 2024
…impleDescriptorHandler.handle() as it needs it to provision encryption query string password (apache#288)

Change-Id: Ib40377ac374c45332eca38948ef1f11c4e14ba75
stoty pushed a commit to stoty/knox that referenced this pull request May 14, 2024
…() to SimpleDescriptorHandler.handle() as it needs it to provision encryption query string password (apache#288)" into cdpd-master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants