KNOX-2295 - UI services improvement on Knox Home page#289
KNOX-2295 - UI services improvement on Knox Home page#289smolnar82 merged 3 commits intoapache:masterfrom
Conversation
|
One comment: the Hue logo you are seeing in the above screenshot is replaced with one with white background. |
moresandeep
left a comment
There was a problem hiding this comment.
I don't have expertise in TypeScript so cannot comment on it. Looking at the UI, it looks really good.
Some really minor things
- Looks like the "Cloudera" logo is disproportionately bigger than other logos.
- For cases where we don't have logos, do you think the description text would look better against white background than the grey one?
- Hue UI logo seems to have a non-white background.
Thanks, this really looks cool now!
|
Thanks, @moresandeep !
|
There was a problem hiding this comment.
So my one big concern is with the Cloudera logo and if we are allowed to copy it into the project. Apache Knox is Apache licensed so any logos would need to be licensed correctly and have proper notices for copying them into the project. I don't know what is all involved here, but it is something we need to be aware of before copying in these logos.
There is a minor version different for the angular dependencies which is minor compared to the above.
| }, | ||
| "private": true, | ||
| "dependencies": { | ||
| "@angular/cdk": "^5.2.5", |
There was a problem hiding this comment.
All the other angular versions is 5.2.0 but this is 5.2.5?
|
Regarding @risdenk 's comment on licensing: all service logos are logos of Apache projects except for the CM-[UI|API]. I understand his concerns about it and it's a valid question if we want to copy it here. |
|
To address the logo stuff I figured out the following approach should work: I'll add a
|
|
@smolnar82 instead of "service logo comes here" can it instead be the text of the service? It would just be plain text on say a white background. That would probably look better. |
…al logo - in case there is no service logo uploaded



What changes were proposed in this pull request?
Removed the data table when displaying UI services and using the services' logos with Angular's material grid. Long descriptions are shown by hovering over the short descriptions in the footer of each tile.
Services are available when you click on their logos.
How was this patch tested?
Tested manually; see these screenshots:
