Skip to content

KNOX-2295 - UI services improvement on Knox Home page#289

Merged
smolnar82 merged 3 commits intoapache:masterfrom
smolnar82:KNOX-2295
Mar 16, 2020
Merged

KNOX-2295 - UI services improvement on Knox Home page#289
smolnar82 merged 3 commits intoapache:masterfrom
smolnar82:KNOX-2295

Conversation

@smolnar82
Copy link
Copy Markdown
Contributor

@smolnar82 smolnar82 commented Mar 15, 2020

What changes were proposed in this pull request?

Removed the data table when displaying UI services and using the services' logos with Angular's material grid. Long descriptions are shown by hovering over the short descriptions in the footer of each tile.
Services are available when you click on their logos.

How was this patch tested?

Tested manually; see these screenshots:
Screen Shot 2020-03-15 at 11 05 03 PM

Screen Shot 2020-03-15 at 11 12 25 PM

@smolnar82
Copy link
Copy Markdown
Contributor Author

One comment: the Hue logo you are seeing in the above screenshot is replaced with one with white background.

Copy link
Copy Markdown
Contributor

@moresandeep moresandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have expertise in TypeScript so cannot comment on it. Looking at the UI, it looks really good.
Some really minor things

  1. Looks like the "Cloudera" logo is disproportionately bigger than other logos.
  2. For cases where we don't have logos, do you think the description text would look better against white background than the grey one?
  3. Hue UI logo seems to have a non-white background.
    Thanks, this really looks cool now!

@smolnar82
Copy link
Copy Markdown
Contributor Author

Thanks, @moresandeep !
Trying to answer your comments:

  1. I'll try to find a better CM logo
  2. If there is no logo -> a JIRA should be submitted. I tried to add logos for all the actively used services.
  3. Hue logo is replaced already (see my comment above)

Copy link
Copy Markdown
Contributor

@risdenk risdenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So my one big concern is with the Cloudera logo and if we are allowed to copy it into the project. Apache Knox is Apache licensed so any logos would need to be licensed correctly and have proper notices for copying them into the project. I don't know what is all involved here, but it is something we need to be aware of before copying in these logos.

There is a minor version different for the angular dependencies which is minor compared to the above.

},
"private": true,
"dependencies": {
"@angular/cdk": "^5.2.5",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other angular versions is 5.2.0 but this is 5.2.5?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested with 5.2.0 as only 5.2.5 was listed as an officially supported version of Angular's material lib:

Screen Shot 2020-03-16 at 3 57 49 PM

@smolnar82
Copy link
Copy Markdown
Contributor Author

Regarding @risdenk 's comment on licensing: all service logos are logos of Apache projects except for the CM-[UI|API]. I understand his concerns about it and it's a valid question if we want to copy it here.

@smolnar82
Copy link
Copy Markdown
Contributor Author

smolnar82 commented Mar 16, 2020

To address the logo stuff I figured out the following approach should work: I'll add a general_logo.png (with the text of 'Service Logo comes here') and display it for

  • any service that does not have its own logo uploaded by this patch (anyone is free to upload their owns logos going forward as a separate patch)
  • CM API/UI (because I'm going to remove the CM logo -> CM will fall into the above category)

@smolnar82
Copy link
Copy Markdown
Contributor Author

This is how it looks like now:
Screen Shot 2020-03-16 at 5 09 48 PM

@smolnar82 smolnar82 requested a review from risdenk March 16, 2020 16:14
@risdenk
Copy link
Copy Markdown
Contributor

risdenk commented Mar 16, 2020

@smolnar82 instead of "service logo comes here" can it instead be the text of the service? It would just be plain text on say a white background. That would probably look better.

…al logo - in case there is no service logo uploaded
@smolnar82
Copy link
Copy Markdown
Contributor Author

Newest version:
Screen Shot 2020-03-16 at 6 16 24 PM

@smolnar82 smolnar82 merged commit 36155bc into apache:master Mar 16, 2020
@smolnar82 smolnar82 deleted the KNOX-2295 branch March 16, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants