Skip to content

Conversation

@lokeshj1703
Copy link
Contributor

@lokeshj1703 lokeshj1703 commented Apr 13, 2020

https://issues.apache.org/jira/browse/KNOX-2321

What changes were proposed in this pull request?

Add a rewrite rule for LogLevel in hdfs ui.

How was this patch tested?

The patch was tested on a cluster.

@risdenk risdenk requested a review from moresandeep April 13, 2020 17:19
@risdenk risdenk self-assigned this Apr 13, 2020
@risdenk risdenk changed the title KNOX-2321. /LogLevel with knox not working for Hdfs web ui endpoints. KNOX-2321 - HDFS UI rewrite rules should handle LogLevel Apr 13, 2020
@bharatviswa504
Copy link

This link is added to DN and explorer page also, do we need some changes for Dn and explorer rewrite rules also to make it work?

@moresandeep
Copy link
Contributor

This link is added to DN and explorer page also, do we need some changes for Dn and explorer rewrite rules also to make it work?

We probably, should, @lokeshj1703 thoughts?

@lmccay
Copy link
Contributor

lmccay commented Apr 13, 2020

Would the other UIs be addressed via global rewrite rules by any chance?

@moresandeep
Copy link
Contributor

Would the other UIs be addressed via global rewrite rules by any chance?

Global rewrite rule is a double edge sword, it might break other UIs unknowingly. I think some code duplication might be tolerable in this case.

@lmccay
Copy link
Contributor

lmccay commented Apr 14, 2020

Okay - I want to cut an RC in the next day or so - so let's get this resolved.

@moresandeep
Copy link
Contributor

Ah right, I'll merge this and we will followup with new JIRA if needed.

@moresandeep moresandeep merged commit 4127124 into apache:master Apr 14, 2020
@lokeshj1703
Copy link
Contributor Author

@bharatviswa504 @moresandeep I think it should be fine. The rewrite rules are added under section.
<!-- outbound rewrite rules for links under utilities -->
I think these rewrite rules apply for datanode as well as explorer html.

stoty pushed a commit to stoty/knox that referenced this pull request May 14, 2024
… ui endpoints. (apache#314)

Change-Id: I2a59ba8de4e8a359a8909145723f7820e461a762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants