KNOX-2355 - Update Atlas rewrite.xml/service.xml for new Atlas UI changes#323
Merged
moresandeep merged 5 commits intoapache:masterfrom Apr 22, 2020
Merged
KNOX-2355 - Update Atlas rewrite.xml/service.xml for new Atlas UI changes#323moresandeep merged 5 commits intoapache:masterfrom
moresandeep merged 5 commits intoapache:masterfrom
Conversation
moresandeep
reviewed
Apr 22, 2020
Contributor
moresandeep
left a comment
moresandeep
left a comment
There was a problem hiding this comment.
@nixonrodrigues a lot of outbound rules have been taken out, is the old UI thoroughly tested? I just want to make sure we are not breaking anything.
moresandeep
requested changes
Apr 22, 2020
gateway-service-definitions/src/main/resources/services/atlas/2.0.0/rewrite.xml
Show resolved
Hide resolved
moresandeep
requested changes
Apr 22, 2020
Contributor
moresandeep
left a comment
moresandeep
left a comment
There was a problem hiding this comment.
We should not change 2.0.0 files.
gateway-service-definitions/src/main/resources/services/atlas/2.0.0/rewrite.xml
Show resolved
Hide resolved
moresandeep
reviewed
Apr 22, 2020
gateway-service-definitions/src/main/resources/services/atlas-api/2.1.0/rewrite.xml
Outdated
Show resolved
Hide resolved
added 3 commits
April 22, 2020 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Updated service.xml and rewrite.xml for Atlas new UI. removed unnecessary rewrite for path and links. Updated Atlas UI end code to handle routing according.
How was this patch tested?
Tested this patch for with Atlas via Knox proxy
Please review Knox Contributing Process before opening a pull request.