KNOX-2562 - TokenStateService getTokenMetadata method should throw Un… #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smolnar82
requested changes
Mar 30, 2021
| @Override | ||
| public TokenMetadata getTokenMetadata(String tokenId) { | ||
| public TokenMetadata getTokenMetadata(String tokenId) throws UnknownTokenException { | ||
| TokenMetadata tokenMetadata = super.getTokenMetadata(tokenId); |
Contributor
There was a problem hiding this comment.
UnknownTokenException should be handled. In HA case it may happen that the in-memory collection will not have the given token metadata -> super will throw UTE. We should catch it and continue with the alias service action.
moresandeep
approved these changes
Mar 30, 2021
…knownTokenException
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
…knownTokenException (apache#426) Change-Id: Ib42a813237a04d94d40779beff9c74672331f18e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…knownTokenException
What changes were proposed in this pull request?
To align with other methods in the TokenStateService interface, the getTokenMetadata(String tokenId) method has modified to throw UnknownTokenException when there is no metadata for the specified token identifier.
How was this patch tested?
Existing tests have been modified/executed, and I've added org.apache.knox.gateway.services.token.impl.DefaultTokenStateServiceTest#testGetMetadata_InvalidToken(), which also gets invoked for the Alias- and Journal-based TokenStateService implementations.