KNOX-2597 - Falling back to AliasBasedTokenStateService in case of DB configuration issues #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmccay
requested changes
Apr 30, 2021
Contributor
lmccay
left a comment
lmccay
left a comment
There was a problem hiding this comment.
Looks good, Sandor.
Just a couple nits.
gateway-applications/src/main/resources/applications/tokengen/app/js/tokengen.js
Outdated
Show resolved
Hide resolved
...-server/src/main/java/org/apache/knox/gateway/services/factory/TokenStateServiceFactory.java
Show resolved
Hide resolved
...service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java
Outdated
Show resolved
Hide resolved
...service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java
Outdated
Show resolved
Hide resolved
… configuration issues Additionally, we display informative status messages on the tokengen application UI about the configured token management backend.
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
… case of DB configuration issues (apache#441) Additionally, we display informative status messages on the tokengen application UI about the configured token management backend. Change-Id: I54541e03f1db8a22e00ffdad5ef8ddc971f7547c
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
…cdpd-master * changes: CDPD-25826 KNOX-2602 - Added the enabled flag and related token service API into the tokens' metadata. (apache#447) CDPD-25826 KNOX-2600 - It's now possible to setup a PostgreSQL connection using a JDBC URL (apache#444) CDPD-25826 KNOX-2599 - Improve tokengen UI (apache#443) CDPD-25826 KNOX-2598 - Added SSL connection support for PostgreSQL database type in JDBC token state management (apache#442) CDPD-25826 KNOX-2597 - Falling back to AliasBasedTokenStateService in case of DB configuration issues (apache#441)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The following features are implemented by this change:
tokengenUI there is new information displayed about token managementHow was this patch tested?
Updated and executed JUnit test. I also run manual testing:
homepagetopologygateway-site.xml-> falling back toAliasBasedtokenStateServicegateway-site.xml-> falling back toAliasBasedtokenStateService. I also setknox.token.exp.tokengen.allowed.tss.backendsin thehomepage.xmltoJDBCTokenStateService