KNOX-2606 - Indicate configured token TTL on UI and ask for confirmation when end-users try to generate a token above the configured limit#450
Merged
smolnar82 merged 1 commit intoapache:masterfrom May 20, 2021
Conversation
…ion when end-users try to generate a token above the configured limit
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
…r confirmation when end-users try to generate a token above the configured limit (apache#450) Change-Id: Ie70da2ccab431ac82c7e117c93b58f6a4def8e00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In order to avoid misunderstandings and customer escalations, the token generation UI now indicates what is the configured maximum lifetime (
knox.token.ttlin the relevant topology). In case end-users wants to generate a token that exceeds the configured maximum, a confirmation window is shown where we explain the side effects.Please note that if
knox.token.ttlis set to-1the topology owner explicitly configuredunlimited lifetime, so we do not need to check the supplied lifespan.How was this patch tested?
Manually tested.