Skip to content

KNOX-2774 - "usage: sleep seconds" messages in terminal after starting knox#606

Merged
smolnar82 merged 1 commit intoapache:masterfrom
MrtnBalazs:KNOX-2774
Jul 8, 2022
Merged

KNOX-2774 - "usage: sleep seconds" messages in terminal after starting knox#606
smolnar82 merged 1 commit intoapache:masterfrom
MrtnBalazs:KNOX-2774

Conversation

@MrtnBalazs
Copy link
Contributor

What changes were proposed in this pull request?

Changed the value of DEFAULT_APP_STATUS_TEST_RETRY_SLEEP from 2s to 2 in knox-functions.sh, because sleep command in BSD family of operating systems (such as FreeBSD) or macOS/mac OS X does NOT take any suffix arguments (m/h/d). It only takes arguments in seconds.

How was this patch tested?

I tested it manually.
Before the change:

mbalazs-MBP15:test mbalazs$ bin/gateway.sh start
usage: sleep seconds
usage: sleep seconds
.
.
.
usage: sleep seconds
usage: sleep seconds
Starting Gateway succeeded with PID 55659.

After the change:

mbalazs-MBP15:test mbalazs$ bin/gateway.sh start
Starting Gateway succeeded with PID 55659.

I also tried a request using curl -k -u tom:tom-password https://localhost:8443/gateway/sandbox/hive and got

2022-07-07 14:50:25,037 726f3103-8de2-4ff8-9bc8-f47f8929da49 INFO  knox.gateway (KnoxLdapRealm.java:getUserDn(688)) - Computed userDn: uid=tom,ou=people,dc=hadoop,dc=apache,dc=org using dnTemplate for principal: tom

@MrtnBalazs
Copy link
Contributor Author

@zeroflag @smolnar82

@zeroflag zeroflag requested review from smolnar82 and zeroflag July 7, 2022 12:54
Copy link
Contributor

@smolnar82 smolnar82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smolnar82 smolnar82 merged commit 4366185 into apache:master Jul 8, 2022
stoty pushed a commit to stoty/knox that referenced this pull request May 14, 2024
…lue from 2s to 2 (apache#606)

Change-Id: I29a81d8629da16a99dd615097b30cb2156efe2e7
stoty pushed a commit to stoty/knox that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants