KNOX-2782 - Enhanced Shiro config with the object class of invalidRequest #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
… invalidRequest (apache#610) Change-Id: Ic0eb422e5aa9603ad49d52f0bcd1b331666d537b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In order to make the
user-auth-testKnoxCLI command work after the 1.6 Shiro upgrade, I'd to add theinvalidRequestfilter's object class (org.apache.shiro.web.filter.InvalidRequestFilter) into themainsection in the generated shiro.ini. Without that change, an error was thrown (see the corresponding JIRA).How was this patch tested?
Ran the
GatewayShiroAuthTestthat covers use-cases for Shiro LDAP authentication including a valid service URL with a semicolon (;jsessionid=OI24B9ASD7BSSD).Other than this I made sure the
user-auth-testKnoxCLI command works: