Skip to content

KNOX-2799 - When exporting certificate using Knox CLI, the certificate is coming with wrong name when type=PEM #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zeroflag merged 2 commits into from
Sep 7, 2022
Merged

KNOX-2799 - When exporting certificate using Knox CLI, the certificate is coming with wrong name when type=PEM #629

zeroflag merged 2 commits into from
Sep 7, 2022

Conversation

@zeroflag
Copy link
Contributor

@zeroflag zeroflag commented Sep 6, 2022 •
edited
Loading

What changes were proposed in this pull request?

There is an inconsistency in naming of the output file of the export cert command. The doc says it should be gateway-client-trust.<type> but in case of pem it's gateway-identity.pem.

How was this patch tested?

$ bin/knoxcli.sh export-cert --type pem
Certificate gateway-identity has been successfully exported to: /Users/attilamagyar/development/test/data/security/keystores/gateway-client-trust.pem
$  ls -al  /Users/attilamagyar/development/test/data/security/keystores/gateway-client-trust.pem
-rw-r--r--  1 attilamagyar  staff  1246 Sep  6 10:28 /Users/attilamagyar/development/test/data/security/keystores/gateway-client-trust.pem

@zeroflag zeroflag self-assigned this Sep 6, 2022
smolnar82
smolnar82 approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@smolnar82 smolnar82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeroflag zeroflag merged commit 3b0c1bb into apache:master Sep 7, 2022
@zeroflag zeroflag deleted the KNOX-2799-pem branch September 7, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smolnar82 smolnar82 smolnar82 approved these changes

@moresandeep moresandeep Awaiting requested review from moresandeep

Assignees

@zeroflag zeroflag

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zeroflag @smolnar82