KNOX-2855:Added Hbase UI proxying for prometheus end points#704
Merged
smolnar82 merged 1 commit intoapache:masterfrom Dec 19, 2022
Merged
KNOX-2855:Added Hbase UI proxying for prometheus end points#704smolnar82 merged 1 commit intoapache:masterfrom
smolnar82 merged 1 commit intoapache:masterfrom
Conversation
smolnar82
requested review from
MrtnBalazs,
moresandeep,
smolnar82 and
zeroflag
stoty
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(It is very important that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!)
What changes were proposed in this pull request?
In HBASE-20904 we added support for /prometheus endpoints under Hbase WebUI.
So in this PR added configurations to make sure that /prometheus endpoints works fine through the proxy.
How was this patch tested?
Copied the patched files "rewrite.xml" and "service.xml" into knox directory and restarted the knox. When opened the Hbase WebUI, the /prometheus endpoint started working as expected. Earlier it used to give 404 error without proxying configurations.
(Please explain how this patch was tested. For instance: running automated unit/integration tests, manual tests. Please write down your test steps as detailed as possible)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Knox Contributing Process before opening a pull request.