KNOX-1864: Implement PATCH method #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Checked and this looks similar to the HEAD patch that fixed that issue. Planning to merge. |
twmarshall
pushed a commit
to twmarshall/knox
that referenced
this pull request
Aug 27, 2019
… with HTTP PATCH method (apache#91) Change-Id: I23f147b76d965b357c350c1b38761d9886e5572c Signed-off-by: Kevin Risden <krisden@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(It is very important that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!)
What changes were proposed in this pull request?
the PATCH http method was not implemented and is necessary for certain REST api's (e.g. Apache Metron) to function.
How was this patch tested?
It was tested by manually replacing the gateway-spi jar by the newly built one and validating if the expected functionality works properly.
Before the patch, Knox would return a 405 http error when a patch request was submitted. After the patch, a 200 OK is returned as expected.
Please review Knox Contributing Process before opening a pull request.