Convert the timeout parameter from an integer to a double value

[Yangsx-1]

Search before asking

• I had searched in the issues and found no similar issues.

Motivation

In redis, the timeout parameter of commands like BLPOP is a double value, but in kvrocks, the parameter must be an integer.

Solution

We can change parseint in the Parse function into parsefloat.

Are you willing to submit a PR?

• I'm willing to submit a PR!

[git-hulk]

Hi @Yangsx-1

Many thanks for your feedback. It should be a mistake in the Redis document, the timeout in the BLPOP is an integer indeed: https://github.com/redis/redis/blob/b00a2351865bb1d87e2d2701b77c8a68daefb054/src/t_list.c#L1218

[Yangsx-1]

Hi @Yangsx-1

Many thanks for your feedback. It should be a mistake in the Redis document, the timeout in the BLPOP is an integer indeed: https://github.com/redis/redis/blob/b00a2351865bb1d87e2d2701b77c8a68daefb054/src/t_list.c#L1218

But i tested it locally, timeout can be floating-point number?

[git-hulk]

Hi @Yangsx-1
Many thanks for your feedback. It should be a mistake in the Redis document, the timeout in the BLPOP is an integer indeed: https://github.com/redis/redis/blob/b00a2351865bb1d87e2d2701b77c8a68daefb054/src/t_list.c#L1218

But i tested it locally, timeout can be floating-point number?

oh, good. You're right that Redis will parse it as a double when the unit is a second:https://github.com/redis/redis/blob/b00a2351865bb1d87e2d2701b77c8a68daefb054/src/timeout.c#L171.

[git-hulk]

@Yangsx-1 assigned, thanks for your good catch.