Conversation
2 tasks
2 tasks
2 tasks
2 tasks
git-hulk
added a commit
that referenced
this pull request
Sep 25, 2025
For the data race details, refer to [GitHub Action Logs](https://github.com/apache/kvrocks/actions/runs/17972329716/job/51119679082?pr=3196): ``` WARNING: ThreadSanitizer: data race (pid=90210) Write of size 8 at 0x7b1c00017030 by thread T150 (mutexes: write M0): #0 Server::AsyncScanDBSize(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)::$_9::operator()() const /home/runner/work/kvrocks/kvrocks/src/server/server.cc:1636:44 (kvrocks+0x15ddb14) (BuildId: dca9d021cc579ae4) #1 void std::__invoke_impl<void, Server::AsyncScanDBSize(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)::$_9&>(std::__invoke_other, Server::AsyncScanDBSize(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)::$_9&) /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/invoke.h:61:14 (kvrocks+0x15ddb14) ... Previous read of size 8 at 0x7b1c00017030 by thread T145 (mutexes: read M1): #0 Server::GetLastScanTime(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const /home/runner/work/kvrocks/kvrocks/src/server/server.cc:1652:25 (kvrocks+0x15bc3aa) (BuildId: dca9d021cc579ae4) #1 Server::GetKeyspaceInfo(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/runner/work/kvrocks/kvrocks/src/server/server.cc:1418:57 (kvrocks+0x15bc3aa) #2 Server::GetInfo(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&)::$_5::operator()(Server*) const /home/runner/work/kvrocks/kvrocks/src/server/server.cc:1454:91 (kvrocks+0x15cafbc) (BuildId: dca9d021cc579ae4) ```
PragmaTwice
pushed a commit
that referenced
this pull request
Oct 18, 2025
) If migrate-batch-rate-limit-mb value is 0,It will cause kvrocks exception of Ooops! Apache Kvrocks version kvrocks_v2.12.1 got signal: Floating point exception (8) E20251017 18:06:35.174003 140710573499968 signal_util.h:33] Ooops! Apache Kvrocks version kvrocks_v2.12.1 (commit 8d56734) got signal: Floating point exception (8) E20251017 18:07:39.142195 140710573499968 signal_util.h:35] Stack trace (most recent call first): #0 0x0000561196118d90 in SegvHandler at /kvrocks/src/cli/signal_util.h:34 #1 0x00007ff9cec5751f in __sigaction at /lib/x86_64-linux-gnu/libc.so.6 #2 0x00005611965077ef in rocksdb::GenericRateLimiter::CalculateRefillBytesPerPeriodLocked(long) at /kvrocks/build/_deps/rocksdb-src/util/rate_limiter.cc:317 #3 0x0000561196507acb in rocksdb::NewGenericRateLimiter(long, long, int, rocksdb::RateLimiter::Mode, bool, long) at /kvrocks/build/_deps/rocksdb-src/util/rate_limiter.cc:387 #4 0x0000561195e8b100 in BatchSender::BatchSender(int, unsigned long, unsigned long) at /kvrocks/src/cluster/batch_sender.h:35 #5 0x0000561195e9a889 in SlotMigrator::loop() at /kvrocks/src/cluster/slot_migrate.cc:174 #6 0x000056119695d643 in execute_native_thread_routine at thread.o #7 0x00007ff9ceca9ac2 in pthread_condattr_setpshared at /lib/x86_64-linux-gnu/libc.so.6 #8 0x00007ff9ced3b8bf in __xmknodat at /lib/x86_64-linux-gnu/libc.so.6 E20251017 18:07:39.142345 140710573499968 signal_util.h:36] It would be greatly appreciated if you could submit this crash to https://github.com/apache/kvrocks/issues along with the stacktrace above, logs and any relevant information. --------- Co-authored-by: hulk <hulk.website@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.