Skip to content

Fix incorrect used_db_size value #204

Merged
karelrooted merged 1 commit intoapache:unstablefrom
karelrooted:fix/used-db-size-not-include-default-cf
Mar 16, 2021
Merged

Fix incorrect used_db_size value #204
karelrooted merged 1 commit intoapache:unstablefrom
karelrooted:fix/used-db-size-not-include-default-cf

Conversation

@karelrooted
Copy link
Copy Markdown
Contributor

@karelrooted karelrooted commented Mar 15, 2021

Fix incorrect used_db_size value which always uses the same cf to find the key range

GetApproximateSizes needs the start/end key of the corresponding column family.
But we always use the metadata column family to find the start/end key range.

@karelrooted karelrooted added the bug type bug label Mar 15, 2021
@git-hulk
Copy link
Copy Markdown
Member

Seems the commit message didn't match the PR changes. It should be:

Fix incorrect used_db_size value which always uses the same cf to find the key range

GetApproximateSizes needs the start/end key of the corresponding column family.
But we always use the metadata column family to find the start/end key range.

…d the key range

GetApproximateSizes needs the start/end key of the corresponding column family.
But we always use the metadata column family to find the start/end key range.
@karelrooted karelrooted force-pushed the fix/used-db-size-not-include-default-cf branch from 9f30165 to 9079a05 Compare March 16, 2021 03:13
@karelrooted karelrooted changed the title Fix used_db_size didn't include default cf size Fix incorrect used_db_size value Mar 16, 2021
@karelrooted karelrooted merged commit 7d73a9a into apache:unstable Mar 16, 2021
@ShooterIT ShooterIT mentioned this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants