Fix get corruption writebatch data after psync restart#221
Merged
karelrooted merged 1 commit intoapache:unstablefrom Apr 15, 2021
Merged
Conversation
git-hulk
previously approved these changes
Apr 15, 2021
Member
|
Many thanks to @karelrooted try hard to fix this hidden deep issue. |
…t the header of the writebatch data) after a restart cause by a failed storage->writebatch() , should always set incr_state_ to Incr_batch_size whether storage_->writebatch success or not , so the next incrementBatchLoopCB will start from the right step
karelrooted
force-pushed
the
fix/replication-psync-restart
branch
from
a7ac8cc to
1f8c2c0
Compare
git-hulk
approved these changes
Apr 15, 2021
ShooterIT
approved these changes
Apr 15, 2021
Member
|
@karelrooted I think we need to port back to 1.3 branch |
Contributor
Author
👌 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix get corruption writebatch data (wrongly include writebatch size at the header of the writebatch data) after a restart cause by a failed storage->writebatch() , should always set incr_state_ to Incr_batch_size whether storage_->writebatch success or not , so the next incrementBatchLoopCB will start from the right step