Add support of the CLUSTER RESET command#2210
Merged
git-hulk merged 8 commits intoapache:unstablefrom Apr 1, 2024
Merged
Conversation
caipengbo
reviewed
Mar 31, 2024
caipengbo
approved these changes
Mar 31, 2024
torwig
approved these changes
Mar 31, 2024
|
PragmaTwice
reviewed
Mar 31, 2024
Comment on lines
+849
to
+851
| for (auto &n : slots_nodes_) { | ||
| n = nullptr; | ||
| } |
Member
There was a problem hiding this comment.
why we need to set all elements to nullptr instead of clear()?
Member
Author
There was a problem hiding this comment.
slot_nodes_ is an array and the number of slot is a fixed number, so I think it should be fine to clear them with the null pointer.
jihuayu
approved these changes
Apr 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #2185