Use the QUICKLIST encoding to dump the list payload to compatible with Redis >= 4

[AntiTopQuark]

Close #2253

In order to support the compatibility of old versions of redis,

when using the dump command, QUICKLISTencoding is used instead of QUICKLIST2for LIST encoding.

[PragmaTwice]

Could you write some test cases for your patch? Thank you!

[AntiTopQuark]

Could you write some test cases for your patch? Thank you!

Here I just changed a coding method. The previous tests can still be used. I have now added some corner cases.

[PragmaTwice]

Could you write some test cases for your patch? Thank you!

Here I just changed a coding method. The previous tests can still be used. I have now added some corner cases.

Generally, if we fixed a bug in a patch, we need to add a test case, that should fail without the patch, and succeed after the patch is applied.

[git-hulk]

@AntiTopQuark Thanks for your efforts.

[git-hulk]

I can confirm it also works in Redis 4:

127.0.0.1:6379> RESTORE list 0 "\x0e\x04\x0e\x0e\x00\x00\x00\n\x00\x00\x00\x01\x00\x00\x01d\xff\x0e\x0e\x00\x00\x00\n\x00\x00\x00\x01\x00\x00\x01c\xff\x0e\x0e\x00\x00\x00\n\x00\x00\x00\x01\x00\x00\x01b\xff\x0e\x0e\x00\x00\x00\n\x00\x00\x00\x01\x00\x00\x01a\xff\x06\x003\x06\xd4\x86\x93\xfbvB"
OK
127.0.0.1:6379> lrange list 0 -1
1) "d"
2) "c"
3) "b"
4) "a"

[mapleFU]

General LGTM. Remaining problems are about code styles

[mapleFU]

I didn't dive into logics of RDB carefully, generally this LGTM

[git-hulk]

@AntiTopQuark Need to reformat codes.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud