Refactor db mutex#278
Merged
ShooterIT merged 3 commits intoapache:unstablefrom May 28, 2021
ShooterIT:db-mutex
Merged
Conversation
ShooterIT
added
the
major decision
ShooterIT
commented
May 27, 2021
karelrooted
previously approved these changes
May 27, 2021
karelrooted
approved these changes
May 28, 2021
git-hulk
approved these changes
May 28, 2021
ShooterIT
added a commit
to ShooterIT/kvrocks
that referenced
this pull request
Jul 15, 2021
- Refactor db mutex using rwlock - A implementation of RAII write-first read-write lock using C++11 - Add some tests for rwlock
ShooterIT
added a commit
that referenced
this pull request
Jul 19, 2021
- Refactor db mutex using rwlock - A implementation of RAII write-first read-write lock using C++11 - Add some tests for rwlock
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SubKeyFilter, remove lock to access db, because we callCancelAllBackgroundWork(wait=true)when closing db.now, i think, it is much easy to understand:
closingflag when writing dbI think all accesses of db are protected when closing db.
@bitleak/kvrocks-core-team I know this PR is dangerous, even i don't test for that :). You(@git-hulk and @karelrooted ) already costed much energy to find many bugs before, but I still open that, we should push this project forward, so it is much important to keep code easy to understand and modify, actually i have plan to refactor
ReclaimOldPtr. So ask you to help me review, maybe you can reproduce old bugs conditions to check it.from a saboteur