feat: Add DELPREFIX to delete keys by prefix#2821
Closed
iihimanshuu wants to merge 5 commits intoapache:unstablefrom
iihimanshuu:unstable
Closed
feat: Add DELPREFIX to delete keys by prefix#2821iihimanshuu wants to merge 5 commits intoapache:unstablefrom iihimanshuu:unstable
iihimanshuu wants to merge 5 commits intoapache:unstablefrom
iihimanshuu:unstable
Conversation
iihimanshuu
changed the title
Author
|
@torwig please review |
PragmaTwice
reviewed
Mar 8, 2025
Member
There was a problem hiding this comment.
Hi, thank you for your contribution!
However, there are still lots of code style changes. If you want to format the code, please use clang-format 14 with respect of our .clang-format in the root directory (clang-format will find the file automatically). Please avoid to introduce unrelated code changes.
Also, the CI workflow will check if the code style is clang-formatted (with correct format configuration) and block the PR if it is not. (like the current situation.)
update 2
update 3
update 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
I introduced updates in two files: commander.cc and cmd_key.cc. The primary changes involve the CommandDelPrefix and RegisterToCommandTable functions. Additionally, there are numerous lines of code changes due to the application of clang-format, which reformatted the codebase for consistency and readability.