-
Notifications
You must be signed in to change notification settings - Fork 604
chore(deps): Bump RocksDB version to v10.7.5 #3232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Same as #3229 (comment). |
Could we update this rocksdb version after our next release(might be 2.14.0)? because it's about time to release our next version, and we can avoid requiring a compiler upgrade for it. |
I think yes, its a good idea |
|
As I think, now we can merge this PR into upstream? |
Yes, I think it's good to go. |
|
There is a stable failure in Alpine 3 CI. Need some investigation. https://github.com/apache/kvrocks/actions/runs/20409431635/job/58647113948?pr=3232 |
After extensive testing, I identified the root cause of the broken CI tests: the Alpine version used in the tests is too new. Alpine 3.23 introduces many changes, some of which cause compatibility issues. Specifically, our C++ tests for the Cluster fail to start and crash without any output. As a quick fix, this PR switches to Alpine 3.22 by updating the image version in the CI matrix This patch fix a bugs into #3329 #3328 #3232
Bump RocksDB version to v10.7.5 (see: https://github.com/facebook/rocksdb/releases/tag/v10.7.5)
Please merge after PR #3229
Key changes