Skip to content

fix(ci): the sonar c/cpp action has been deprecated#3280

Merged
PragmaTwice merged 2 commits intoapache:unstablefrom
git-hulk:fix/sonnar-action
Dec 1, 2025
Merged

fix(ci): the sonar c/cpp action has been deprecated#3280
PragmaTwice merged 2 commits intoapache:unstablefrom
git-hulk:fix/sonnar-action

Conversation

@git-hulk
Copy link
Member

@git-hulk git-hulk commented Dec 1, 2025

No description provided.

@git-hulk git-hulk marked this pull request as draft December 1, 2025 02:40
PragmaTwice
PragmaTwice reviewed Dec 1, 2025
View reviewed changes
PragmaTwice
PragmaTwice reviewed Dec 1, 2025
View reviewed changes
@PragmaTwice
Copy link
Member

PragmaTwice commented Dec 1, 2025

https://github.com/apache/kvrocks/blob/unstable/.github/workflows/sonar.yaml

This action should also be fixed. IMHO now the simplest way is to use sonarqube-github-c-cpp.

@git-hulk
Copy link
Member Author

git-hulk commented Dec 1, 2025 •
edited
Loading

https://github.com/apache/kvrocks/blob/unstable/.github/workflows/sonar.yaml

This action should also be fixed. IMHO now the simplest way is to use sonarqube-github-c-cpp.

This requires adding this archived action to Apache's allowed list. Let me try the SonarSource/sonarqube-scan-action.

@PragmaTwice
Copy link
Member

PragmaTwice commented Dec 1, 2025

https://github.com/apache/kvrocks/blob/unstable/.github/workflows/sonar.yaml

Ahh sorry, wrong file. https://github.com/apache/kvrocks/blob/unstable/.github/workflows/kvrocks.yaml this should also be fixed.

@git-hulk
Copy link
Member Author

git-hulk commented Dec 1, 2025

https://github.com/apache/kvrocks/blob/unstable/.github/workflows/sonar.yaml

Ahh sorry, wrong file. https://github.com/apache/kvrocks/blob/unstable/.github/workflows/kvrocks.yaml this should also be fixed.

Oh, I see. I did miss this file, which also has the Sonar build wrapper.

@git-hulk git-hulk marked this pull request as ready for review December 1, 2025 05:31
@git-hulk git-hulk requested a review from PragmaTwice December 1, 2025 05:31
@PragmaTwice PragmaTwice merged commit e939165 into apache:unstable Dec 1, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@git-hulk @PragmaTwice