fix(server): data race when accessing the db scan infos in GetLatestKeyNumStats#3414
Merged
git-hulk merged 2 commits intoApr 1, 2026
Merged
Conversation
git-hulk
changed the title
git-hulk
approved these changes
Apr 1, 2026
PragmaTwice
approved these changes
Apr 1, 2026
|
nagisa-kunhah
pushed a commit
to nagisa-kunhah/kvrocks
that referenced
this pull request
Apr 29, 2026
…eyNumStats (apache#3414) db_scan_infos_.find() was called without holding db_job_mu_, while background threads mutate the map under that lock. Acquire the lock before find() to match the pattern used in GetLastScanTime. Co-authored-by: hulk <hulk.website@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
db_scan_infos_.find() was called without holding db_job_mu_, while
background threads mutate the map under that lock. Acquire the lock
before find() to match the pattern used in GetLastScanTime.