fix(conf): cap proto-max-bulk-len to 4 GiB instead of UINT64_MAX #3419
Merged
git-hulk merged 4 commits intoapache:unstablefrom Apr 5, 2026
Merged
fix(conf): cap proto-max-bulk-len to 4 GiB instead of UINT64_MAX #3419git-hulk merged 4 commits intoapache:unstablefrom
git-hulk merged 4 commits intoapache:unstablefrom
Conversation
git-hulk
reviewed
Apr 3, 2026
git-hulk
reviewed
Apr 3, 2026
songqing
changed the title
songqing
changed the title
git-hulk
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRLF accounting in RESP parsing can never wrap around, see
if (evbuffer_get_length(input) < bulk_len_ + 2) return Status::OK();in code4 GiB is chosen because:
- RocksDB recommends keeping individual values under 3 GiB for
performance and memory reasons.
- It eliminates both the uint64_t overflow and the ssize_t cast hazard.
- It is still far above any realistic bulk string size in practice.