fix(string,hash): use compact float format in IncrByFloat to match Redis#3427
Merged
Merged
Conversation
songqing
commented
Apr 8, 2026
Contributor
git-hulk
approved these changes
Apr 8, 2026
jihuayu
approved these changes
Apr 8, 2026
PragmaTwice
approved these changes
Apr 8, 2026
|
nagisa-kunhah
pushed a commit
to nagisa-kunhah/kvrocks
that referenced
this pull request
Apr 29, 2026
…dis (apache#3427) Previously, String::IncrByFloat and Hash::IncrByFloat used std::to_string(double) to persist float values, which produces C-style %f format with 6 fixed decimal places (e.g., "10.500000"). Redis uses a compact %g-like format that strips trailing zeros (e.g., "10.5"). This caused GET/HGET after INCRBYFLOAT/HINCRBYFLOAT to return values like "10.500000" instead of "10.5", breaking Redis protocol compatibility. Replace std::to_string with util::Float2String (which uses fmt {:.17g}) in both String::IncrByFloat and Hash::IncrByFloat. The INCRBYFLOAT command reply already used Float2String correctly; this fix aligns the stored representation with both the reply format and Redis behavior. Co-authored-by: 纪华裕 <jihuayu123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


