fix(tdigest): correct TDIGEST.MERGE parser for COMPRESSION parameter.#3449
Merged
Conversation
Contributor
Author
|
fix before: after: |
jihuayu
reviewed
Apr 14, 2026
LindaSummer
changed the title
LindaSummer
reviewed
Apr 14, 2026
LindaSummer
left a comment
LindaSummer
left a comment
Member
There was a problem hiding this comment.
Hi @Tangruilin ,
It seems this change involved some unexpected behavior.
It would be better to add related test cases for this scenario.
…pache#3447) The parser incorrectly used two independent `if` statements to check COMPRESSION and OVERRIDE parameters. When COMPRESSION was successfully parsed, the code continued to the second `if` which would fail since the parser had reached the end, causing "ERR wrong keyword" error. Fixed by changing the second `if` to `else if` to form a proper if-else-if-else chain. Signed-off-by: reilly <reilly@example.com>
jihuayu
approved these changes
Apr 15, 2026
LindaSummer
approved these changes
Apr 15, 2026
|
nagisa-kunhah
pushed a commit
to nagisa-kunhah/kvrocks
that referenced
this pull request
Apr 29, 2026
…apache#3449) Fix apache#3447 The parser incorrectly used two independent `if` statements to check COMPRESSION and OVERRIDE parameters. When COMPRESSION was successfully parsed, the code continued to the second `if` which would fail since the parser had reached the end, causing "ERR wrong keyword" error. Fixed by changing the second `if` to `else if` to form a proper if-else-if-else chain. Signed-off-by: reilly <reilly@example.com> Co-authored-by: 纪华裕 <jihuayu123@gmail.com>
nagisa-kunhah
pushed a commit
to nagisa-kunhah/kvrocks
that referenced
this pull request
Apr 29, 2026
…apache#3449) Fix apache#3447 The parser incorrectly used two independent `if` statements to check COMPRESSION and OVERRIDE parameters. When COMPRESSION was successfully parsed, the code continued to the second `if` which would fail since the parser had reached the end, causing "ERR wrong keyword" error. Fixed by changing the second `if` to `else if` to form a proper if-else-if-else chain. Signed-off-by: reilly <reilly@example.com> Co-authored-by: 纪华裕 <jihuayu123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(#3447)
The parser incorrectly used two independent
ifstatements to check COMPRESSION and OVERRIDE parameters. When COMPRESSION was successfully parsed, the code continued to the secondifwhich would fail since the parser had reached the end, causing "ERR wrong keyword" error.Fixed by changing the second
iftoelse ifto form a proper if-else-if-else chain.