fix(test): extend the replication wait time to prevent the flaky test#3531
Merged
PragmaTwice merged 1 commit intoJun 18, 2026
Merged
Conversation
…sfer flake
Currently, WaitForSync only allows 5s for master_link_status to reach "up",
which is not enough under loaded CI runners (e.g. SonarCloud coverage builds);
Reproduced locally by running 16 background CPU burners and looping the test:
for i in $(seq 1 6); do
go test -count=1 -run TestReplicationWithLimitSpeed$ \
./integration/replication/... \
-binPath=.../build/kvrocks -workspace=/tmp/kvrocks-test-ws
done
Before the fix: 1/6 runs failed with the same trace as the CI flake
("Condition never satisfied" at client.go:50, called from replication_test.go:362).
After the fix: 8/8 runs pass under the same CPU load (run times 34-51s vs. an
unloaded baseline of ~28s, confirming load was active).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
git-hulk
changed the title
git-hulk
changed the title
PragmaTwice
approved these changes
Jun 18, 2026
Member
|
This PR is related to the issue #3515. |
jihuayu
approved these changes
Jun 18, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, WaitForSync only allows 5s for master_link_status to reach "up",
which is not enough under loaded CI runners (e.g. SonarCloud coverage builds);
Reproduced locally by running 16 background CPU burners and looping the test:
Before the fix: 1/6 runs failed with the same trace as the CI flake
("Condition never satisfied" at client.go:50, called from replication_test.go:362).
After the fix: 8/8 runs pass under the same CPU load (run times 34-51s vs. an
unloaded baseline of ~28s, confirming load was active).
Related flaky run: https://github.com/apache/kvrocks/actions/runs/27660686644/job/81804342125
🤖 Generated with Claude Code