Skip to content

KYLIN-4433 use cube config when uhc step enabled#1168

Merged
shaofengshi merged 1 commit intoapache:masterfrom
ChangjiGuo:KYLIN-4433
Mar 26, 2020
Merged

KYLIN-4433 use cube config when uhc step enabled#1168
shaofengshi merged 1 commit intoapache:masterfrom
ChangjiGuo:KYLIN-4433

Conversation

@ChangjiGuo
Copy link

issue: https://issues.apache.org/jira/browse/KYLIN-4433
If the system level configuration is used, it will cause the dictionary to be built repeatedly, so I think the configuration of the cube should be used here.
Thanks!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5785

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 27.523%

Changes Missing Coverage Covered Lines Changed/Added Lines %
engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java 1 81.08%
Totals Coverage Status
Change from base Build 5776: 0.003%
Covered Lines: 24306
Relevant Lines: 88310

💛 - Coveralls

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@shaofengshi shaofengshi merged commit 87bc875 into apache:master Mar 26, 2020
@shaofengshi
Copy link
Contributor

Thank you Changji! Next time if you can add the JIRA id in git commit message, that would be great! like "KYLIN-4433 use cube config when uhc step enabled"

@ChangjiGuo
Copy link
Author

@shaofengshi ok, next time i will pay attention. I am very glad to contribute to the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants