KYLIN-4433 use cube config when uhc step enabled#1168
Merged
shaofengshi merged 1 commit intoapache:masterfrom Mar 26, 2020
ChangjiGuo:KYLIN-4433
Merged
KYLIN-4433 use cube config when uhc step enabled#1168shaofengshi merged 1 commit intoapache:masterfrom ChangjiGuo:KYLIN-4433
shaofengshi merged 1 commit intoapache:masterfrom
ChangjiGuo:KYLIN-4433
Conversation
Pull Request Test Coverage Report for Build 5785
💛 - Coveralls |
Contributor
|
Thank you Changji! Next time if you can add the JIRA id in git commit message, that would be great! like "KYLIN-4433 use cube config when uhc step enabled" |
Author
|
@shaofengshi ok, next time i will pay attention. I am very glad to contribute to the community! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: https://issues.apache.org/jira/browse/KYLIN-4433
If the system level configuration is used, it will cause the dictionary to be built repeatedly, so I think the configuration of the cube should be used here.
Thanks!