KYLIN-4434 Sometimes the segments of submitted unsuccessfully will be stored in cube storage

[zhangayqian]

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I have create an issue on Kylin's jira, and have described the bug/feature there in detail
• Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
• Compiling and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• If this change need a document change, I will prepare another pr against the document branch
• Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

[codecov-io]

Codecov Report

Merging #1169 into master will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1169      +/-   ##
============================================
- Coverage     25.06%   25.01%   -0.06%     
- Complexity     6250     6251       +1     
============================================
  Files          1446     1449       +3     
  Lines         88309    88498     +189     
  Branches      12358    12375      +17     
============================================
+ Hits          22136    22137       +1     
- Misses        64003    64185     +182     
- Partials       2170     2176       +6     

Impacted Files	Coverage Δ	Complexity Δ
...java/org/apache/kylin/rest/service/JobService.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java	72.97% <0.00%> (-5.41%)	6.00% <0.00%> (-1.00%)
...org/apache/kylin/rest/util/QueryRequestLimits.java	35.71% <0.00%> (-4.77%)	5.00% <0.00%> (-1.00%)
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java	63.84% <0.00%> (-2.31%)	0.00% <0.00%> (ø%)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java	70.21% <0.00%> (-0.92%)	7.00% <0.00%> (ø%)
...he/kylin/engine/mr/common/MapReduceExecutable.java	12.91% <0.00%> (-0.42%)	6.00% <0.00%> (ø%)
...c/main/java/org/apache/kylin/cube/CubeManager.java	36.50% <0.00%> (-0.12%)	44.00% <0.00%> (ø%)
...n/java/org/apache/kylin/tool/DiagnosisInfoCLI.java	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
...ava/org/apache/kylin/tool/JobDiagnosisInfoCLI.java	0.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
.../java/org/apache/kylin/common/util/HadoopUtil.java	14.56% <0.00%> (ø)	10.00% <0.00%> (ø%)
... and 24 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 734a997...87caa96. Read the comment docs.

[shaofengshi]

Hi Yaqian, firstly, please provide the issue description for it in the JIRA, so that others can understand the problem.

Secondly, catch a "throwable" is a bad practice, you can do some search, like https://stackoverflow.com/questions/6083248/is-it-a-bad-practice-to-catch-throwable

[zhangayqian]

Hi Yaqian, firstly, please provide the issue description for it in the JIRA, so that others can understand the problem.

Secondly, catch a "throwable" is a bad practice, you can do some search, like https://stackoverflow.com/questions/6083248/is-it-a-bad-practice-to-catch-throwable

Hi Shaofeng:
I have update the info of KYLIN-4434, provide the issue description for it and explain the reason of catch a "throwable". Maybe there is a better way to deal with this problem?