Skip to content

KYLIN-4426 CliCommandExecutor#1175

Merged
nichunen merged 1 commit intoapache:masterfrom
hit-lacus:KYLIN-4426-2
Apr 14, 2020
Merged

KYLIN-4426 CliCommandExecutor#1175
nichunen merged 1 commit intoapache:masterfrom
hit-lacus:KYLIN-4426-2

Conversation

@hit-lacus
Copy link
Copy Markdown
Member

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1175 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1175      +/-   ##
============================================
- Coverage     25.02%   25.01%   -0.02%     
  Complexity     6254     6254              
============================================
  Files          1449     1449              
  Lines         88499    88501       +2     
  Branches      12373    12373              
============================================
- Hits          22148    22139       -9     
- Misses        64177    64185       +8     
- Partials       2174     2177       +3     
Impacted Files Coverage Δ Complexity Δ
...g/apache/kylin/common/util/CliCommandExecutor.java 30.48% <100.00%> (+1.73%) 8.00 <3.00> (+2.00)
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 72.97% <0.00%> (-5.41%) 6.00% <0.00%> (-1.00%)
...org/apache/kylin/rest/util/QueryRequestLimits.java 35.71% <0.00%> (-4.77%) 5.00% <0.00%> (-1.00%)
...ream/core/storage/columnar/ColumnarStoreCache.java 52.27% <0.00%> (-3.41%) 8.00% <0.00%> (ø%)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 70.21% <0.00%> (-0.92%) 7.00% <0.00%> (ø%)
...pache/kylin/job/impl/curator/CuratorScheduler.java 64.40% <0.00%> (-0.85%) 7.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6745acb...c9e7b60. Read the comment docs.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 5819

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.0006%) to 27.479%

Files with Coverage Reduction New Missed Lines %
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java 2 57.95%
Totals Coverage Status
Change from base Build 5800: -0.0006%
Covered Lines: 24319
Relevant Lines: 88501

💛 - Coveralls

@hit-lacus hit-lacus force-pushed the KYLIN-4426-2 branch 2 times, most recently from 1199244 to 6ed4177 Compare April 13, 2020 09:04
Copy link
Copy Markdown

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nichunen nichunen merged commit 335d61b into apache:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants