Skip to content

KYLIN-4441 Add restart command to kylin.sh#1176

Merged
nichunen merged 1 commit intoapache:masterfrom
zhangayqian:KYLIN-4441
Apr 13, 2020
Merged

KYLIN-4441 Add restart command to kylin.sh#1176
nichunen merged 1 commit intoapache:masterfrom
zhangayqian:KYLIN-4441

Conversation

@zhangayqian
Copy link
Copy Markdown
Contributor

@zhangayqian zhangayqian commented Apr 10, 2020

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1176 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1176      +/-   ##
============================================
- Coverage     25.06%   25.01%   -0.06%     
- Complexity     6250     6251       +1     
============================================
  Files          1446     1449       +3     
  Lines         88309    88499     +190     
  Branches      12358    12373      +15     
============================================
- Hits          22136    22134       -2     
- Misses        64003    64187     +184     
- Partials       2170     2178       +8     
Impacted Files Coverage Δ Complexity Δ
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 72.97% <0.00%> (-5.41%) 6.00% <0.00%> (-1.00%)
...org/apache/kylin/rest/util/QueryRequestLimits.java 35.71% <0.00%> (-4.77%) 5.00% <0.00%> (-1.00%)
...va/org/apache/kylin/cube/common/SegmentPruner.java 58.46% <0.00%> (-4.04%) 26.00% <0.00%> (+1.00%) ⬇️
...he/kylin/job/impl/threadpool/DefaultScheduler.java 74.41% <0.00%> (-2.33%) 12.00% <0.00%> (ø%)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 70.21% <0.00%> (-0.92%) 7.00% <0.00%> (ø%)
...a/org/apache/kylin/dict/Number2BytesConverter.java 81.74% <0.00%> (-0.80%) 17.00% <0.00%> (-1.00%)
...he/kylin/engine/mr/common/MapReduceExecutable.java 12.91% <0.00%> (-0.42%) 6.00% <0.00%> (ø%)
...ain/java/org/apache/kylin/engine/mr/CubingJob.java 1.53% <0.00%> (-0.04%) 2.00% <0.00%> (ø%)
...n/java/org/apache/kylin/tool/DiagnosisInfoCLI.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ava/org/apache/kylin/tool/JobDiagnosisInfoCLI.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 734a997...8ce3d3e. Read the comment docs.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 5821

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.005%) to 27.475%

Files with Coverage Reduction New Missed Lines %
core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java 2 80.23%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java 2 57.95%
Totals Coverage Status
Change from base Build 5800: -0.005%
Covered Lines: 24315
Relevant Lines: 88499

💛 - Coveralls

Copy link
Copy Markdown

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@nichunen nichunen merged commit fa4f72d into apache:master Apr 13, 2020
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.01%. Comparing base (734a997) to head (8ce3d3e).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1176      +/-   ##
============================================
- Coverage     25.06%   25.01%   -0.06%     
- Complexity     6250     6251       +1     
============================================
  Files          1446     1449       +3     
  Lines         88309    88499     +190     
  Branches      12358    12373      +15     
============================================
- Hits          22136    22134       -2     
- Misses        64003    64187     +184     
- Partials       2170     2178       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants