Skip to content

Comments

KYLIN-4508 Add more unit tests to improve test coverage#1228

Closed
kyotoYaho wants to merge 2 commits intoapache:masterfrom
kyotoYaho:APACHE-KYLIN-4508
Closed

KYLIN-4508 Add more unit tests to improve test coverage#1228
kyotoYaho wants to merge 2 commits intoapache:masterfrom
kyotoYaho:APACHE-KYLIN-4508

Conversation

@kyotoYaho
Copy link

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@kyotoYaho kyotoYaho force-pushed the APACHE-KYLIN-4508 branch from 4208239 to 984dc81 Compare May 22, 2020 07:50
@codecov-commenter
Copy link

Codecov Report

Merging #1228 into master will increase coverage by 1.10%.
The diff coverage is 56.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1228      +/-   ##
============================================
+ Coverage     24.85%   25.96%   +1.10%     
- Complexity     6266     6520     +254     
============================================
  Files          1453     1453              
  Lines         89225    89243      +18     
  Branches      12456    12458       +2     
============================================
+ Hits          22181    23173     +992     
+ Misses        64869    63810    -1059     
- Partials       2175     2260      +85     
Impacted Files Coverage Δ Complexity Δ
...org/apache/kylin/metrics/lib/impl/RecordEvent.java 72.04% <0.00%> (+72.04%) 24.00 <0.00> (+24.00)
...pache/kylin/metrics/lib/impl/TimePropertyEnum.java 73.68% <ø> (+73.68%) 4.00 <0.00> (+4.00)
...pache/kylin/engine/mr/common/JobInfoConverter.java 60.29% <58.33%> (+31.61%) 23.00 <0.00> (+2.00)
...ache/kylin/metrics/lib/impl/BlockingReservoir.java 53.33% <66.66%> (+53.33%) 13.00 <2.00> (+13.00)
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 72.97% <0.00%> (-5.41%) 6.00% <0.00%> (-1.00%)
...org/apache/kylin/rest/util/QueryRequestLimits.java 35.71% <0.00%> (-4.77%) 5.00% <0.00%> (-1.00%)
...he/kylin/job/impl/threadpool/DefaultScheduler.java 74.41% <0.00%> (-2.33%) 12.00% <0.00%> (ø%)
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 63.84% <0.00%> (-2.31%) 0.00% <0.00%> (ø%)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.30% <0.00%> (-1.83%) 7.00% <0.00%> (ø%)
...ache/kylin/engine/mr/common/AbstractHadoopJob.java 15.94% <0.00%> (+0.50%) 3.00% <0.00%> (+1.00%)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7886a24...984dc81. Read the comment docs.

@shaofengshi
Copy link
Contributor

Merged by manual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants